summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos
diff options
context:
space:
mode:
authorsatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-16 11:04:45 +0000
committersatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-16 11:04:45 +0000
commit29d40036eed4e3d0f5658d13a5cbc2b9eb447c4f (patch)
tree3a49a53168d5b0ee492c7a50309d6e4ff00820e5 /chrome/browser/chromeos
parentb12634bd944bae2499ac3ade524cc2b890ec7961 (diff)
downloadchromium_src-29d40036eed4e3d0f5658d13a5cbc2b9eb447c4f.zip
chromium_src-29d40036eed4e3d0f5658d13a5cbc2b9eb447c4f.tar.gz
chromium_src-29d40036eed4e3d0f5658d13a5cbc2b9eb447c4f.tar.bz2
chromeos: Implement a TODO to rename the class TextInputSection as well
the section name in System Options. BUG=None TEST=compiles Review URL: http://codereview.chromium.org/935001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41707 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos')
-rw-r--r--chrome/browser/chromeos/options/system_page_view.cc46
1 files changed, 22 insertions, 24 deletions
diff --git a/chrome/browser/chromeos/options/system_page_view.cc b/chrome/browser/chromeos/options/system_page_view.cc
index 32db4a4..bce4338 100644
--- a/chrome/browser/chromeos/options/system_page_view.cc
+++ b/chrome/browser/chromeos/options/system_page_view.cc
@@ -308,18 +308,16 @@ void TouchpadSection::NotifyPrefChanged(const std::wstring* pref_name) {
}
////////////////////////////////////////////////////////////////////////////////
-// TextInputSection
+// LanguageSection
// TextInput section for text input settings.
-class TextInputSection : public SettingsPageSection,
- public views::ButtonListener {
+class LanguageSection : public SettingsPageSection,
+ public views::ButtonListener {
public:
- explicit TextInputSection(Profile* profile);
- virtual ~TextInputSection() {}
+ explicit LanguageSection(Profile* profile);
+ virtual ~LanguageSection() {}
private:
- views::NativeButton* customize_languages_button_;
-
// Overridden from SettingsPageSection:
virtual void InitContents(GridLayout* layout);
@@ -327,17 +325,27 @@ class TextInputSection : public SettingsPageSection,
virtual void ButtonPressed(views::Button* sender,
const views::Event& event);
- DISALLOW_COPY_AND_ASSIGN(TextInputSection);
+ views::NativeButton* customize_languages_button_;
+
+ DISALLOW_COPY_AND_ASSIGN(LanguageSection);
};
-// TODO(satorux): Should change the class name as well as the section
-// title. "Text Input" doesn't seem to be a good section name.
-TextInputSection::TextInputSection(Profile* profile)
+LanguageSection::LanguageSection(Profile* profile)
: SettingsPageSection(profile,
- IDS_OPTIONS_SETTINGS_SECTION_TITLE_TEXT_INPUT) {
+ IDS_OPTIONS_SETTINGS_SECTION_TITLE_LANGUAGE) {
+}
+
+void LanguageSection::InitContents(GridLayout* layout) {
+ // Add the customize button.
+ layout->StartRow(0, single_column_view_set_id());
+ customize_languages_button_ = new views::NativeButton(
+ this,
+ l10n_util::GetString(IDS_OPTIONS_SETTINGS_LANGUAGES_CUSTOMIZE));
+ layout->AddView(customize_languages_button_, 1, 1,
+ GridLayout::LEADING, GridLayout::CENTER);
}
-void TextInputSection::ButtonPressed(
+void LanguageSection::ButtonPressed(
views::Button* sender, const views::Event& event) {
if (sender == customize_languages_button_) {
views::Window* window = views::Window::CreateChromeWindow(
@@ -349,16 +357,6 @@ void TextInputSection::ButtonPressed(
}
}
-void TextInputSection::InitContents(GridLayout* layout) {
- // Add the customize button.
- layout->StartRow(0, single_column_view_set_id());
- customize_languages_button_ = new views::NativeButton(
- this,
- l10n_util::GetString(IDS_OPTIONS_SETTINGS_LANGUAGES_CUSTOMIZE));
- layout->AddView(customize_languages_button_, 1, 1,
- GridLayout::LEADING, GridLayout::CENTER);
-}
-
////////////////////////////////////////////////////////////////////////////////
// SystemPageView
@@ -381,7 +379,7 @@ void SystemPageView::InitControlLayout() {
layout->AddView(new TouchpadSection(profile()));
layout->AddPaddingRow(0, kRelatedControlVerticalSpacing);
layout->StartRow(0, single_column_view_set_id);
- layout->AddView(new TextInputSection(profile()));
+ layout->AddView(new LanguageSection(profile()));
layout->AddPaddingRow(0, kRelatedControlVerticalSpacing);
}