diff options
| author | csilv@chromium.org <csilv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-23 19:45:34 +0000 |
|---|---|---|
| committer | csilv@chromium.org <csilv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-23 19:45:34 +0000 |
| commit | 753a1cd3dbd242201d86c216ed1b80b7a0d0a139 (patch) | |
| tree | 0c45c66d859b504fa59e065ba0ce0e0156ea8100 /chrome/browser/chromeos | |
| parent | d766aee04c48cd44888fa32300d72aa005964e6e (diff) | |
| download | chromium_src-753a1cd3dbd242201d86c216ed1b80b7a0d0a139.zip chromium_src-753a1cd3dbd242201d86c216ed1b80b7a0d0a139.tar.gz chromium_src-753a1cd3dbd242201d86c216ed1b80b7a0d0a139.tar.bz2 | |
yRevert 57093 - dom-ui options: record user metrics for pref changes.
BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3190004
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3119038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57096 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/chromeos')
| -rw-r--r-- | chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc | 9 | ||||
| -rw-r--r-- | chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h | 3 |
2 files changed, 3 insertions, 9 deletions
diff --git a/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc b/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc index a8355cd..4f66cd7 100644 --- a/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc +++ b/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.cc @@ -7,7 +7,6 @@ #include "base/json/json_reader.h" #include "base/string_number_conversions.h" #include "chrome/browser/chromeos/cros_settings.h" -#include "chrome/browser/metrics/user_metrics.h" #include "chrome/common/notification_service.h" namespace chromeos { @@ -31,11 +30,9 @@ void CoreChromeOSOptionsHandler::ObservePref(const std::string& pref_name) { void CoreChromeOSOptionsHandler::SetPref(const std::string& pref_name, Value::ValueType pref_type, - const std::string& value_string, - const std::string& metric) { + const std::string& value_string) { if (!CrosSettings::IsCrosSettings(pref_name)) - return ::CoreOptionsHandler::SetPref(pref_name, pref_type, value_string, - metric); + return ::CoreOptionsHandler::SetPref(pref_name, pref_type, value_string); CrosSettings* cros_settings = CrosSettings::Get(); switch (pref_type) { @@ -60,8 +57,6 @@ void CoreChromeOSOptionsHandler::SetPref(const std::string& pref_name, break; } } - - ProcessUserMetric(pref_type, value_string, metric); } void CoreChromeOSOptionsHandler::Observe(NotificationType type, diff --git a/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h b/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h index aa58c29..80acdd3 100644 --- a/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h +++ b/chrome/browser/chromeos/dom_ui/core_chromeos_options_handler.h @@ -20,8 +20,7 @@ class CoreChromeOSOptionsHandler : public ::CoreOptionsHandler { virtual void ObservePref(const std::string& pref_name); virtual void SetPref(const std::string& pref_name, Value::ValueType pref_type, - const std::string& value_string, - const std::string& metric); + const std::string& value_string); // NotificationObserver implementation. virtual void Observe(NotificationType type, |