Mousing over the bookmark bar now behaves properly when traversing a non-folder item; this would previously cause folder menus to discontinue appearing. Now once the bar folder menus are showing they will continue showing even when a non-folder bookmark bar item is traversed. Folder menus will discontinue showing when 1) a bar folder button is clicked, 2) a bookmark choice is made, 3) a click is made somewhere else in the browser window, 4) when the window loses focus, etc.

BUG=None
TEST=1) Mouse over the bar without clicking and verify that no folder menus appear. 2) Click on a folder button in the bar and verify that its folder menu appears. 3) Mouse over other folders in the bar and verify that the old menu closes and a new one opens. 4) Mouse over a non-folder button in the bar and verify that the old menu closes and another does not appear. 5) Mouse over a folder button and verify that the folder's menu appears. 6) Click on a folder button in the bar and verify that the menu closes. 7) Mouse over other folder buttons and verify no menu appears.

Review URL: http://codereview.chromium.org/1912008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46626 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 7 insertions, 0 deletions

diff --git a/chrome/browser/cocoa/bookmark_bar_controller.h b/chrome/browser/cocoa/bookmark_bar_controller.h
index 29952b8..a0ccd31 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller.h
+++ b/chrome/browser/cocoa/bookmark_bar_controller.h
@@ -213,6 +213,13 @@ willAnimateFromState:(bookmarks::VisualState)oldState
   // that all bookmark buttons we create will be visible.  Thus,
   // [buttons_ count] isn't a definitive check.
   int displayedButtonCount_;
+
+  // A state flag which tracks when the bar's folder menus should be shown.
+  // An initial click in any of the folder buttons turns this on and
+  // one of the following will turn it off: another click in the button,
+  // the window losing focus, a click somewhere other than in the bar
+  // or a folder menu.
+  BOOL showFolderMenus_;
 }
 
 @property(readonly, nonatomic) bookmarks::VisualState visualState;