summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/bookmark_bar_controller.h
diff options
context:
space:
mode:
authorjrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-12 03:12:49 +0000
committerjrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-03-12 03:12:49 +0000
commit58dd56d1be3b5b4dcba851aebd59b8d3645685e8 (patch)
tree10421ea2adf2f44fd33cc5a4eaa15a722156e238 /chrome/browser/cocoa/bookmark_bar_controller.h
parent3cb29296dd9eb603f033a527e33f5e40eea90c9d (diff)
downloadchromium_src-58dd56d1be3b5b4dcba851aebd59b8d3645685e8.zip
chromium_src-58dd56d1be3b5b4dcba851aebd59b8d3645685e8.tar.gz
chromium_src-58dd56d1be3b5b4dcba851aebd59b8d3645685e8.tar.bz2
Bookmark bar menu/folder button text is left-aligned, not centered.
Bookmark bar menu/folder maximum window width is now 1000, not 150. High cosmetic impact. BUG=36487, 17608 TEST=\ 1) Add bookmarks on the bar with small (e.g. 'x') and big titles. Make sure all looks OK (e.g. small ones are small.) 2) Add bookmarks in a folder. Make sure text is left aligned on the menus. 3) Add bookmarks in a folder with long names (e.g. 100 characters). Make sure folder/menus are now much wider. 4) Add bookmarks in a folder with mega long names (e.g. 4000 characters). Make sure menus have a maximum size of ~1000 pixes (no need to be exact but 'no limit' is fail). 5) In a folder, add a subfolder named 'x' and a bookmark with a REAL long name. Make sure the "button" (menu item) is the full width of the menu. Review URL: http://codereview.chromium.org/842005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41387 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_bar_controller.h')
-rw-r--r--chrome/browser/cocoa/bookmark_bar_controller.h7
1 files changed, 7 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_controller.h b/chrome/browser/cocoa/bookmark_bar_controller.h
index 8d2c117..f5ad45b 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller.h
+++ b/chrome/browser/cocoa/bookmark_bar_controller.h
@@ -39,7 +39,14 @@ namespace bookmarks {
// Magic numbers from Cole
// TODO(jrg): create an objc-friendly version of bookmark_bar_constants.h?
+// Used as a maximum width for buttons on the bar.
const CGFloat kDefaultBookmarkWidth = 150.0;
+
+// TODO(jrg): http://crbug.com/36276 to get final sizes.
+// Used as a min/max width for buttons on menus (not on the bar).
+const CGFloat kBookmarkMenuButtonMinimumWidth = kDefaultBookmarkWidth;
+const CGFloat kBookmarkMenuButtonMaximumWidth = 1000.0;
+
const CGFloat kBookmarkVerticalPadding = 2.0;
const CGFloat kBookmarkHorizontalPadding = 1.0;