diff options
| author | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-11 02:10:26 +0000 |
|---|---|---|
| committer | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-11 02:10:26 +0000 |
| commit | 403784516b6a77f997707df538b10befff488bd8 (patch) | |
| tree | 7fc8644229436f7cb098135d85055a6b489f1245 /chrome/browser/cocoa/bookmark_bar_controller_unittest.mm | |
| parent | caf6a6aadaa15f9e3ffe92ed938e5151cf8d05ea (diff) | |
| download | chromium_src-403784516b6a77f997707df538b10befff488bd8.zip chromium_src-403784516b6a77f997707df538b10befff488bd8.tar.gz chromium_src-403784516b6a77f997707df538b10befff488bd8.tar.bz2 | |
Revert 44201 - Once the initial URL is opened in a new window, insure that subsequent URLs are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so.
BUG=39901
TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, topmost window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window".
Review URL: http://codereview.chromium.org/1634004
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/1520032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44202 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_bar_controller_unittest.mm')
| -rw-r--r-- | chrome/browser/cocoa/bookmark_bar_controller_unittest.mm | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm b/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm index 7facb96..44de1e9 100644 --- a/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm +++ b/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm @@ -520,8 +520,6 @@ TEST_F(BookmarkBarControllerTest, OpenBookmark) { EXPECT_EQ(bar_.get()->dispositions_[0], CURRENT_TAB); } -// TODO(mrossetti):Add OpenBookmarkInNewWindow test. - // Confirm opening of bookmarks works from the menus (different // dispositions than clicking on the button). TEST_F(BookmarkBarControllerTest, OpenBookmarkFromMenus) { @@ -750,10 +748,6 @@ TEST_F(BookmarkBarControllerTest, OpenAllBookmarks) { EXPECT_EQ(bar_.get()->dispositions_.size(), 2U); } -// TODO(mrossetti):Add OpenAllBookmarkInNewWindow test. - -// TODO(mrossetti):Add OpenAllBookmarkInIncognitoWindow test. - // TODO(jrg): write a test to confirm that nodeFavIconLoaded calls // checkForBookmarkButtonGrowth:. |