diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-30 20:59:53 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-30 20:59:53 +0000 |
| commit | fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0 (patch) | |
| tree | 914d030330c7221ed57b81f8146283ef08abdddb /chrome/browser/cocoa/bookmark_bar_folder_controller.h | |
| parent | 7cd363601dfdaad7d3c9a36f4a4085e5e039fa05 (diff) | |
| download | chromium_src-fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0.zip chromium_src-fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0.tar.gz chromium_src-fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0.tar.bz2 | |
Vertical scrolling arrows in bookmark bar folder windows when needed.
pdfs from Cole.
BUG=42026
TEST=\
1) Small folders --> no arrows.
2) Big folders --> arrow at bottom initially.
3) Move browser to bottom of screen so a small folder falls off the bottom and has an arrow.
Open it and gently use scroll wheel to scroll. Make sure transition to "no arrow" looks good.
Close and reopen. Scroll super-fast. Make sure it ends up in the same nice place.
4) Open big big folder. Scroll so top goes offscreen so you now have 2 scroll arrows.
Use scroll wheel to gently go up and down (arrow hides and shows). Make sure transitions OK.
Scroll all the way so bottom arrow disappears. Gently up and down; watch for transitions.
Now FAST up and down. Make sure destination looks OK.
BookmarkBarFolderWindow.xib change: BookmarkBarFolderWindowScrollView border turned off.
Review URL: http://codereview.chromium.org/1813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46114 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_bar_folder_controller.h')
| -rw-r--r-- | chrome/browser/cocoa/bookmark_bar_folder_controller.h | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_folder_controller.h b/chrome/browser/cocoa/bookmark_bar_folder_controller.h index 8b88253..59efa65 100644 --- a/chrome/browser/cocoa/bookmark_bar_folder_controller.h +++ b/chrome/browser/cocoa/bookmark_bar_folder_controller.h @@ -64,6 +64,9 @@ // always visible. BOOL scrollable_; + BOOL scrollUpArrowShown_; + BOOL scrollDownArrowShown_; + // The main view of this window (where the buttons go). IBOutlet BookmarkBarFolderView* mainView_; @@ -100,6 +103,10 @@ // Amount to scroll by on each timer fire. Can be + or -. CGFloat verticalScrollDelta_; + + // We need to know the size of the vertical scrolling arrows so we + // can obscure/unobscure them. + CGFloat verticalScrollArrowHeight_; } // Designated initializer. @@ -150,5 +157,10 @@ - (id)folderTarget; - (void)configureWindowLevel; - (void)performOneScroll:(CGFloat)delta; + +// Return YES if we can scroll up or down. +- (BOOL)canScrollUp; +- (BOOL)canScrollDown; + @end |