diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-30 20:59:53 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-30 20:59:53 +0000 |
| commit | fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0 (patch) | |
| tree | 914d030330c7221ed57b81f8146283ef08abdddb /chrome/browser/cocoa/bookmark_bar_folder_window.h | |
| parent | 7cd363601dfdaad7d3c9a36f4a4085e5e039fa05 (diff) | |
| download | chromium_src-fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0.zip chromium_src-fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0.tar.gz chromium_src-fdc04cc5d7d91c38efcfb6c9f7881930e4baa1c0.tar.bz2 | |
Vertical scrolling arrows in bookmark bar folder windows when needed.
pdfs from Cole.
BUG=42026
TEST=\
1) Small folders --> no arrows.
2) Big folders --> arrow at bottom initially.
3) Move browser to bottom of screen so a small folder falls off the bottom and has an arrow.
Open it and gently use scroll wheel to scroll. Make sure transition to "no arrow" looks good.
Close and reopen. Scroll super-fast. Make sure it ends up in the same nice place.
4) Open big big folder. Scroll so top goes offscreen so you now have 2 scroll arrows.
Use scroll wheel to gently go up and down (arrow hides and shows). Make sure transitions OK.
Scroll all the way so bottom arrow disappears. Gently up and down; watch for transitions.
Now FAST up and down. Make sure destination looks OK.
BookmarkBarFolderWindow.xib change: BookmarkBarFolderWindowScrollView border turned off.
Review URL: http://codereview.chromium.org/1813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46114 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_bar_folder_window.h')
| -rw-r--r-- | chrome/browser/cocoa/bookmark_bar_folder_window.h | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_folder_window.h b/chrome/browser/cocoa/bookmark_bar_folder_window.h index c35bd2e3..7337521 100644 --- a/chrome/browser/cocoa/bookmark_bar_folder_window.h +++ b/chrome/browser/cocoa/bookmark_bar_folder_window.h @@ -6,6 +6,9 @@ #define CHROME_BROWSER_COCOA_BOOKMARK_BAR_FOLDER_WINDOW_H_ #import <Cocoa/Cocoa.h> +#import "base/cocoa_protocols_mac.h" +#include "base/scoped_nsobject.h" + // Window for a bookmark folder "menu". This menu pops up when you // click on a bookmark button that represents a folder of bookmarks. @@ -15,7 +18,11 @@ // Content view for the above window. "Stock" other than the drawing // of rounded corners. Only used in the nib. -@interface BookmarkBarFolderWindowContentView : NSView +@interface BookmarkBarFolderWindowContentView : NSView { + // Arrows to show ability to scroll up and down as needed. + scoped_nsobject<NSImage> arrowUpImage_; + scoped_nsobject<NSImage> arrowDownImage_; +} @end // Scroll view that contains the main view (where the buttons go). |