(

Retry of http://codereview.chromium.org/1731001
Try servers not helpful since this includes a binary file.
Unfortunately I did a --gtest_filter=BookmarkBar\* to self-test
which did not include BookmarkButton* tests :-(
Only change is "size" to "cellSize" on 2nd to last line of TEST_F(BookmarkButtonCellTest, FolderArrow)
)


UI review follow-up for m5 bookmark bar deliverables

Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
works; has a little leak-thru)

BUG=42026
TEST=see description

xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView 


Review URL: http://codereview.chromium.org/1709004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45196 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 19 insertions, 0 deletions

diff --git a/chrome/browser/cocoa/bookmark_bar_folder_window.mm b/chrome/browser/cocoa/bookmark_bar_folder_window.mm
index 6cae7c5..732bed1 100644
--- a/chrome/browser/cocoa/bookmark_bar_folder_window.mm
+++ b/chrome/browser/cocoa/bookmark_bar_folder_window.mm
@@ -4,7 +4,9 @@
 
 #import "chrome/browser/cocoa/bookmark_bar_folder_window.h"
 
+#import "base/logging.h"
 #import "base/scoped_nsobject.h"
+#import "chrome/browser/cocoa/bookmark_bar_folder_controller.h"
 #import "third_party/GTM/AppKit/GTMNSColor+Luminance.h"
 #import "third_party/GTM/AppKit/GTMNSBezierPath+RoundRect.h"
 
@@ -72,3 +74,20 @@ const CGFloat kViewCornerRadius = 4.0;
 }
 
 @end
+
+
+@implementation BookmarkBarFolderWindowScrollView
+
+// We want "draw background" of the NSScrollView in the xib to be NOT
+// checked.  That allows us to round the bottom corners of the folder
+// window.  However that also allows some scrollWheel: events to leak
+// into the NSWindow behind it (even in a different application).
+// Better to plug the scroll leak than to round corners for M5.
+- (void)scrollWheel:(NSEvent *)theEvent {
+  DCHECK([[[self window] windowController]
+           respondsToSelector:@selector(scrollWheel:)]);
+  [[[self window] windowController] scrollWheel:theEvent];
+}
+
+
+@end