Mac: Animate the bookmark bar showing/hiding.

There's a huge refactoring of the bookmark bar controller in this CL, so that animation-related code is in only a few places (instead of scattered all over the place).

Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from AnimatableView, I had to hook up its delegate_ member to File's Owner (i.e., the BookmarkBarController).

Not yet implemented: morphing between the detached bar (on the NTP) and anything else.

BUG=25600
TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch it animate.

Review URL: http://codereview.chromium.org/384105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31977 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 6 deletions

diff --git a/chrome/browser/cocoa/bookmark_bar_toolbar_view.h b/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
index 0eb79ca..2232309 100644
--- a/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
+++ b/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
@@ -12,9 +12,8 @@
 
 #import <Cocoa/Cocoa.h>
 
-#import "chrome/browser/cocoa/background_gradient_view.h"
+#import "chrome/browser/cocoa/animatable_view.h"
 
-@protocol BookmarkBarFloating;
 @class BookmarkBarView;
 class TabContents;
 class ThemeProvider;
@@ -22,8 +21,8 @@ class ThemeProvider;
 // An interface to allow mocking of a BookmarkBarController by the
 // BookmarkBarToolbarView.
 @protocol BookmarkBarToolbarViewController
-// Displaying the bookmark toolbar background in floating mode requires the
-// size of the currently selected tab to properly calculate where the
+// Displaying the bookmark toolbar background in bubble (floating) mode requires
+// the size of the currently selected tab to properly calculate where the
 // background image is joined.
 - (int)currentTabContentsHeight;
 
@@ -32,11 +31,11 @@ class ThemeProvider;
 
 // Returns true if the bookmark bar should be drawn as if it's a disconnected
 // bookmark bar on the New Tag Page.
-- (BOOL)drawAsFloatingBar;
+- (BOOL)isShownAsDetachedBar;
 
 @end
 
-@interface BookmarkBarToolbarView : BackgroundGradientView {
+@interface BookmarkBarToolbarView : AnimatableView {
  @private
    // The controller which tells us how we should be drawing (as normal or as a
    // floating bar).