Add the "Other bookmarks" button on the right of the bookmark bar.

Lots of fixes to deal better with the floating bar on the
  NTP (e.g. chevron resize, chevron enabling only when there is
  overflow, ...)

Move layoutSubviews logic from bookmark_bar_toolbar_view to
  bookmark_bar_controller to better honor MVC.

BUG=http://crbug.com/24985, http://crbug.com/24827, http://crbug.com/22018

TEST=Lots of moves:
New browser with no bookmarks.
Go to New Tab Page.  Show Bookmark Bar.  
See "Other Bookmarks" button on right.
Do NOT see chevron.
Hover over and click on Other Bookmarks to be sure it doesn't draw out of bounds.
Disable bookmark bar (so it is now floating).
Repeat hover/click test.
Enable (so now attached).
Add bookmarks until chevron shows up.
Repeat hover/click test with chevron and Other Bookmarks.
Make browser wider and thinner; each time repeat hover/click test.
Detach bookmark bar (so floating on NTP).
Make browser wider and thinner; each time repeat hover/click test.
Carefully make browser wider/thinner so chevron appears/disappears.
Make sure chevron never overlaps a bookmark.
With chevron visible, quit & relaunch.  Make sure chevron visible.
With chevron NOT visible, quit & relaunch.  Make sure chevron not visible.


Review URL: http://codereview.chromium.org/348017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30684 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 8 deletions

diff --git a/chrome/browser/cocoa/bookmark_bar_toolbar_view.h b/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
index cfc9288..0eb79ca 100644
--- a/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
+++ b/chrome/browser/cocoa/bookmark_bar_toolbar_view.h
@@ -33,6 +33,7 @@ class ThemeProvider;
 // Returns true if the bookmark bar should be drawn as if it's a disconnected
 // bookmark bar on the New Tag Page.
 - (BOOL)drawAsFloatingBar;
+
 @end
 
 @interface BookmarkBarToolbarView : BackgroundGradientView {
@@ -40,15 +41,7 @@ class ThemeProvider;
    // The controller which tells us how we should be drawing (as normal or as a
    // floating bar).
    IBOutlet id<BookmarkBarToolbarViewController> controller_;
-
-   // The bookmark bar's contents.
-   IBOutlet BookmarkBarView* buttonView_;
 }
-
-// Called by our controller to layout our subviews, so that on new tab pages,
-// we have a border.
-- (void)layoutViews;
-
 @end
 
 #endif  // CHROME_BROWSER_COCOA_BOOKMARK_BAR_TOOLBAR_VIEW_H_