diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 18:14:28 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 18:14:28 +0000 |
| commit | 89622004872be7f7ddaa24fa1694f76c7b9539b6 (patch) | |
| tree | 81b8a42c7649c8cbca99d04305470ccbc1fe61fa /chrome/browser/cocoa/bookmark_bubble_controller.mm | |
| parent | b7544eef7b81458a88597419eed6617c41e6d3dc (diff) | |
| download | chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.zip chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.tar.gz chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.tar.bz2 | |
UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_bubble_controller.mm')
| -rw-r--r-- | chrome/browser/cocoa/bookmark_bubble_controller.mm | 18 |
1 files changed, 11 insertions, 7 deletions
diff --git a/chrome/browser/cocoa/bookmark_bubble_controller.mm b/chrome/browser/cocoa/bookmark_bubble_controller.mm index 7b29749..075034c 100644 --- a/chrome/browser/cocoa/bookmark_bubble_controller.mm +++ b/chrome/browser/cocoa/bookmark_bubble_controller.mm @@ -146,7 +146,8 @@ } - (IBAction)edit:(id)sender { - UserMetrics::RecordAction("BookmarkBubble_Edit", model_->profile()); + UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Edit"), + model_->profile()); [self showEditor]; } @@ -169,7 +170,8 @@ - (IBAction)remove:(id)sender { model_->SetURLStarred(node_->GetURL(), node_->GetTitle(), false); - UserMetrics::RecordAction("BookmarkBubble_Unstar", model_->profile()); + UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"), + model_->profile()); node_ = NULL; // no longer valid [self ok:sender]; } @@ -181,8 +183,9 @@ NSMenuItem* selected = [folderPopUpButton_ selectedItem]; ChooseAnotherFolder* chooseItem = [[self class] chooseAnotherFolderObject]; if ([[selected representedObject] isEqual:chooseItem]) { - UserMetrics::RecordAction("BookmarkBubble_EditFromCombobox", - model_->profile()); + UserMetrics::RecordAction( + UserMetricsAction("BookmarkBubble_EditFromCombobox"), + model_->profile()); [self showEditor]; } } @@ -210,8 +213,9 @@ NSString* newTitle = [nameTextField_ stringValue]; if (![oldTitle isEqual:newTitle]) { model_->SetTitle(node_, base::SysNSStringToWide(newTitle)); - UserMetrics::RecordAction("BookmarkBubble_ChangeTitleInBubble", - model_->profile()); + UserMetrics::RecordAction( + UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"), + model_->profile()); } // Then the parent folder. const BookmarkNode* oldParent = node_->GetParent(); @@ -227,7 +231,7 @@ if (oldParent != newParent) { int index = newParent->GetChildCount(); model_->Move(node_, newParent, index); - UserMetrics::RecordAction("BookmarkBubble_ChangeParent", + UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_ChangeParent"), model_->profile()); } } |