diff options
author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 05:45:50 +0000 |
---|---|---|
committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 05:45:50 +0000 |
commit | 72126d044d0e08028ff7055d91d4b7eb5e6fae1a (patch) | |
tree | 86dd0cf6bbb948286502ca9925ceaf8cc8a0c79b /chrome/browser/cocoa/bookmark_button_cell_unittest.mm | |
parent | ed448a7628414a78a8cff6069ecf87b76faa48f2 (diff) | |
download | chromium_src-72126d044d0e08028ff7055d91d4b7eb5e6fae1a.zip chromium_src-72126d044d0e08028ff7055d91d4b7eb5e6fae1a.tar.gz chromium_src-72126d044d0e08028ff7055d91d4b7eb5e6fae1a.tar.bz2 |
Revert 45151 - UI review followup for m5 bookmark bar deliverables
Remove border of the (empty) bookmark item.
Add arrow icons for folders in bookmark bar folder windows (but not on the bar)
Scroll wheel events now scroll the bookmark bar folder windows (mostly
works; has a little leakthru)
BUG=42026
TEST=see description
xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView
Review URL: http://codereview.chromium.org/1731001
TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/1727004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45152 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_button_cell_unittest.mm')
-rw-r--r-- | chrome/browser/cocoa/bookmark_button_cell_unittest.mm | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/chrome/browser/cocoa/bookmark_button_cell_unittest.mm b/chrome/browser/cocoa/bookmark_button_cell_unittest.mm index d7dda3f..da378f1 100644 --- a/chrome/browser/cocoa/bookmark_button_cell_unittest.mm +++ b/chrome/browser/cocoa/bookmark_button_cell_unittest.mm @@ -121,28 +121,4 @@ TEST_F(BookmarkButtonCellTest, Awake) { EXPECT_EQ(NSLeftTextAlignment, [cell alignment]); } -// Subfolder arrow details. -TEST_F(BookmarkButtonCellTest, FolderArrow) { - BookmarkModel* model = helper_.profile()->GetBookmarkModel(); - const BookmarkNode* bar = model->GetBookmarkBarNode(); - const BookmarkNode* node = model->AddURL(bar, bar->GetChildCount(), L"title", - GURL("http://www.google.com")); - scoped_nsobject<BookmarkButtonCell> cell( - [[BookmarkButtonCell alloc] initForNode:node - contextMenu:nil - cellText:@"small" - cellImage:nil]); - EXPECT_TRUE(cell.get()); - - NSSize size = [cell cellSize]; - // sanity check - EXPECT_GE(size.width, 2); - EXPECT_GE(size.height, 2); - - // Once we turn on arrow drawing make sure there is now room for it. - [cell setDrawFolderArrow:YES]; - NSSize arrowSize = [cell size]; - EXPECT_GT(arrowSize.width, size.width); -} - } // namespace |