diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-18 00:38:11 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-18 00:38:11 +0000 |
| commit | e06d95c472709c146248a7cfe0a4bf2bc40942d3 (patch) | |
| tree | 81fb795eb4eecaef4add37d390e7f0ff0bd6a21b /chrome/browser/cocoa/bookmark_menu.h | |
| parent | 5315025a1176b7f077b4bf8d2a963e63ea87f988 (diff) | |
| download | chromium_src-e06d95c472709c146248a7cfe0a4bf2bc40942d3.zip chromium_src-e06d95c472709c146248a7cfe0a4bf2bc40942d3.tar.gz chromium_src-e06d95c472709c146248a7cfe0a4bf2bc40942d3.tar.bz2 | |
Bookmark context menus reference bookmark IDs, not pointers, in case
they go away while the menu is open.
BUG=34522
TEST=\
1) Confirm bookmark context menus continue to work (e.g. rename, delete).
2) Repeat the "sync and delete while context menu" is open test from the
bug; make sure the op is ignored (and we don't crash).
Review URL: http://codereview.chromium.org/1041003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41903 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/bookmark_menu.h')
| -rw-r--r-- | chrome/browser/cocoa/bookmark_menu.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/cocoa/bookmark_menu.h b/chrome/browser/cocoa/bookmark_menu.h index 7a5ff25..5d39edf 100644 --- a/chrome/browser/cocoa/bookmark_menu.h +++ b/chrome/browser/cocoa/bookmark_menu.h @@ -3,16 +3,18 @@ // found in the LICENSE file. #import <Cocoa/Cocoa.h> -struct BookmarkNode; + +#include "base/basictypes.h" + // The context menu for bookmark buttons needs to know which // BookmarkNode it is talking about. For example, "Open All" is // disabled if the bookmark node is a folder and has no children. @interface BookmarkMenu : NSMenu { @private - const BookmarkNode* node_; + int64 id_; // id of the bookmark node we represent. } - (void)setRepresentedObject:(id)object; -@property const BookmarkNode* node; +@property int64 id; @end |