diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-20 21:24:29 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-20 21:24:29 +0000 |
| commit | 7b2b99405d3f5c413cae047291a8c75176f5850d (patch) | |
| tree | b41c5b940df10e7cc53676f25c3e6c7d2ffb7f69 /chrome/browser/cocoa/browser_window_cocoa.mm | |
| parent | 0b305d8786f0ed1c336cb4e78221ca564ba187f7 (diff) | |
| download | chromium_src-7b2b99405d3f5c413cae047291a8c75176f5850d.zip chromium_src-7b2b99405d3f5c413cae047291a8c75176f5850d.tar.gz chromium_src-7b2b99405d3f5c413cae047291a8c75176f5850d.tar.bz2 | |
Bookmark STAR bubble.
BUG=http://crbug.com/14929
Sample image attached to bug.
TEST=Click the STAR to add a bookmark.
Watch bubble come up. Title is "Bookmark added!"
Confirm fields are OK.
Switch tabs and see bubble go away.
Click STAR again.
Watch bubble come up. Title is "Bookmark"
Make sure all the buttons work (Edit, Close, Remove).
Make sure you can change the title and parent folder.
Make sure "Choose another folder..." opens edit window.
Review URL: http://codereview.chromium.org/171016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23886 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/browser_window_cocoa.mm')
| -rw-r--r-- | chrome/browser/cocoa/browser_window_cocoa.mm | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm index 91c6a0f..ff1d813 100644 --- a/chrome/browser/cocoa/browser_window_cocoa.mm +++ b/chrome/browser/cocoa/browser_window_cocoa.mm @@ -202,7 +202,8 @@ void BrowserWindowCocoa::ShowBookmarkManager() { void BrowserWindowCocoa::ShowBookmarkBubble(const GURL& url, bool already_bookmarked) { - NOTIMPLEMENTED(); + [controller_ showBookmarkBubbleForURL:url + alreadyBookmarked:(already_bookmarked ? YES : NO)]; } bool BrowserWindowCocoa::IsDownloadShelfVisible() const { |