diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-20 21:24:29 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-20 21:24:29 +0000 |
| commit | 7b2b99405d3f5c413cae047291a8c75176f5850d (patch) | |
| tree | b41c5b940df10e7cc53676f25c3e6c7d2ffb7f69 /chrome/browser/cocoa/browser_window_controller.h | |
| parent | 0b305d8786f0ed1c336cb4e78221ca564ba187f7 (diff) | |
| download | chromium_src-7b2b99405d3f5c413cae047291a8c75176f5850d.zip chromium_src-7b2b99405d3f5c413cae047291a8c75176f5850d.tar.gz chromium_src-7b2b99405d3f5c413cae047291a8c75176f5850d.tar.bz2 | |
Bookmark STAR bubble.
BUG=http://crbug.com/14929
Sample image attached to bug.
TEST=Click the STAR to add a bookmark.
Watch bubble come up. Title is "Bookmark added!"
Confirm fields are OK.
Switch tabs and see bubble go away.
Click STAR again.
Watch bubble come up. Title is "Bookmark"
Make sure all the buttons work (Edit, Close, Remove).
Make sure you can change the title and parent folder.
Make sure "Choose another folder..." opens edit window.
Review URL: http://codereview.chromium.org/171016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23886 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/browser_window_controller.h')
| -rw-r--r-- | chrome/browser/cocoa/browser_window_controller.h | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/browser_window_controller.h b/chrome/browser/cocoa/browser_window_controller.h index 6713044..eb34d94 100644 --- a/chrome/browser/cocoa/browser_window_controller.h +++ b/chrome/browser/cocoa/browser_window_controller.h @@ -16,6 +16,7 @@ #include "base/scoped_ptr.h" #import "chrome/browser/cocoa/tab_window_controller.h" #import "chrome/browser/cocoa/bookmark_bar_controller.h" +#import "chrome/browser/cocoa/bookmark_bubble_controller.h" #import "chrome/browser/cocoa/view_resizer.h" #import "third_party/GTM/AppKit/GTMTheme.h" @@ -40,6 +41,7 @@ class TabStripModelObserverBridge; @interface BrowserWindowController : TabWindowController<NSUserInterfaceValidations, BookmarkURLOpener, + BookmarkBubbleControllerDelegate, ViewResizer, GTMThemeDelegate> { @private @@ -63,6 +65,7 @@ class TabStripModelObserverBridge; scoped_nsobject<InfoBarContainerController> infoBarContainerController_; scoped_ptr<StatusBubble> statusBubble_; scoped_nsobject<DownloadShelfController> downloadShelfController_; + scoped_nsobject<BookmarkBubbleController> bookmarkBubbleController_; scoped_nsobject<GTMTheme> theme_; BOOL ownsBrowser_; // Only ever NO when testing BOOL fullscreen_; @@ -139,6 +142,10 @@ class TabStripModelObserverBridge; // Delegate method for the status bubble to query about its vertical offset. - (float)verticalOffsetForStatusBubble; +// Show the bookmark bubble (e.g. user just clicked on the STAR) +- (void)showBookmarkBubbleForURL:(const GURL&)url + alreadyBookmarked:(BOOL)alreadyBookmarked; + // Returns the (lazily created) window sheet controller of this window. Used // for the per-tab sheets. - (GTMWindowSheetController*)sheetController; @@ -165,6 +172,9 @@ class TabStripModelObserverBridge; // Return an autoreleased NSWindow suitable for fullscreen use. - (NSWindow*)fullscreenWindow; +// Return a point suitable for the topLeft for a bookmark bubble. +- (NSPoint)topLeftForBubble; + @end // BrowserWindowController(TestingAPI) #endif // CHROME_BROWSER_COCOA_BROWSER_WINDOW_CONTROLLER_H_ |