diff options
author | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-06 03:36:36 +0000 |
---|---|---|
committer | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-06 03:36:36 +0000 |
commit | d1c90bf7270eb0dd62e1e4924d55bd97636762f0 (patch) | |
tree | 5bcafcd0b5d28e3a9000ce0a64a8d487359e5e35 /chrome/browser/cocoa/browser_window_controller.mm | |
parent | 5e81ea70d1c32614b5cb438b05bd2bc8c057fb72 (diff) | |
download | chromium_src-d1c90bf7270eb0dd62e1e4924d55bd97636762f0.zip chromium_src-d1c90bf7270eb0dd62e1e4924d55bd97636762f0.tar.gz chromium_src-d1c90bf7270eb0dd62e1e4924d55bd97636762f0.tar.bz2 |
Change how the calculation is performed for determining the location of the arrow tip in a bubble window.
BUG=40406
TEST=1) Not in full-screen and with language set to English, press Cmd-D and verify bubble is properly positioned with arrow tip pointing to star. Change language to Espanol and repeat test. 2) Now in full-screen, repeat the tests.
Review URL: http://codereview.chromium.org/1623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43694 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/browser_window_controller.mm')
-rw-r--r-- | chrome/browser/cocoa/browser_window_controller.mm | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/chrome/browser/cocoa/browser_window_controller.mm b/chrome/browser/cocoa/browser_window_controller.mm index 05edc1a..65f7b61 100644 --- a/chrome/browser/cocoa/browser_window_controller.mm +++ b/chrome/browser/cocoa/browser_window_controller.mm @@ -1372,14 +1372,12 @@ return phase; } -- (NSPoint)topRightForBubble { +- (NSPoint)pointForBubbleArrowTip { NSRect rect = [toolbarController_ starIconInWindowCoordinates]; - NSPoint p = NSMakePoint(NSMaxX(rect), NSMinY(rect)); // bottom right - - // Adjust top-right based on our knowledge of how the view looks. - p.x += 31; - p.y += 5; - + // Determine the point of the arrow of the bubble window. + NSPoint p = rect.origin; + p.x += (NSWidth(rect) / 2.0) + 1.0; // Star is not exactly in center. + p.y += 4; return p; } |