diff options
| author | rohitrao@chromium.org <rohitrao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-01 18:26:20 +0000 |
|---|---|---|
| committer | rohitrao@chromium.org <rohitrao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-01 18:26:20 +0000 |
| commit | 57f1540c143413d2e1c30bd50ef70ee46f306d69 (patch) | |
| tree | 05b4a18e2963bf0c164921c8c1d69de5db66419e /chrome/browser/cocoa/browser_window_controller_unittest.mm | |
| parent | c7216b9285fa88947aaaee086e7fb9a5fea0c2b9 (diff) | |
| download | chromium_src-57f1540c143413d2e1c30bd50ef70ee46f306d69.zip chromium_src-57f1540c143413d2e1c30bd50ef70ee46f306d69.tar.gz chromium_src-57f1540c143413d2e1c30bd50ef70ee46f306d69.tar.bz2 | |
Revert 57677 - Mark test as flaky that's been failing on Chromium Mac.
BUG=53586
TEST=Mark BrowserWindowFullScreenControllerTest.TestActivate as flaky.
Review URL: http://codereview.chromium.org/3221003
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/3327002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58204 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/browser_window_controller_unittest.mm')
| -rw-r--r-- | chrome/browser/cocoa/browser_window_controller_unittest.mm | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/cocoa/browser_window_controller_unittest.mm b/chrome/browser/cocoa/browser_window_controller_unittest.mm index 01ceff0..0a56165 100644 --- a/chrome/browser/cocoa/browser_window_controller_unittest.mm +++ b/chrome/browser/cocoa/browser_window_controller_unittest.mm @@ -587,8 +587,11 @@ TEST_F(BrowserWindowFullScreenControllerTest, TestFullscreen) { EXPECT_FALSE([controller_ isFullscreen]); } -// Failing on Chromium Mac: http://crbug/53586 -TEST_F(BrowserWindowFullScreenControllerTest, FLAKY_TestActivate) { +// If this test fails, it is usually a sign that the bots have some sort of +// problem (such as a modal dialog up). This tests is a very useful canary, so +// please do not mark it as flaky without first verifying that there are no bot +// problems. +TEST_F(BrowserWindowFullScreenControllerTest, TestActivate) { EXPECT_FALSE([controller_ isFullscreen]); [controller_ activate]; |