diff options
| author | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 20:12:50 +0000 |
|---|---|---|
| committer | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 20:12:50 +0000 |
| commit | c4f0ed1562c5f4f021b17f1d371f77f955968561 (patch) | |
| tree | 3a9724883d519a2b2be43e795cababb1fdfe8758 /chrome/browser/cocoa/browser_window_controller_unittest.mm | |
| parent | dabc3e84a78f0438785e892cf56b4c94cc8d22c3 (diff) | |
| download | chromium_src-c4f0ed1562c5f4f021b17f1d371f77f955968561.zip chromium_src-c4f0ed1562c5f4f021b17f1d371f77f955968561.tar.gz chromium_src-c4f0ed1562c5f4f021b17f1d371f77f955968561.tar.bz2 | |
Make tabs go all the way to the right edge and stop using less of the strip as more tabs are added. Don't resize on selection when tabs are very small, except just enough to show a close box. Clip closebox and favicon as tab gets very small. Fix z-order to be consistent among all unselected tabs. Fix incognito man disappearing when dragging window via the tab. Tabs can now get about as small as they do on windows allowing many more to fit.
BUG=14911, 14913, 17372
TEST=adding and removing lots of tabs and making sure nothing goes wrong.
Review URL: http://codereview.chromium.org/159206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21432 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/browser_window_controller_unittest.mm')
| -rw-r--r-- | chrome/browser/cocoa/browser_window_controller_unittest.mm | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/browser_window_controller_unittest.mm b/chrome/browser/cocoa/browser_window_controller_unittest.mm index be30d9a..f816a76 100644 --- a/chrome/browser/cocoa/browser_window_controller_unittest.mm +++ b/chrome/browser/cocoa/browser_window_controller_unittest.mm @@ -12,6 +12,7 @@ #include "chrome/common/pref_names.h" #include "chrome/common/pref_service.h" #include "chrome/test/testing_browser_process.h" +#include "chrome/test/testing_profile.h" #include "testing/gtest/include/gtest/gtest.h" @interface BrowserWindowController (ExposedForTesting) @@ -110,4 +111,25 @@ TEST_F(BrowserWindowControllerTest, BookmarkBarControllerIndirection) { EXPECT_TRUE([controller_ isBookmarkBarVisible]); } +#if 0 +// TODO(jrg): This crashes trying to create the BookmarkBarController, adding +// an observer to the BookmarkModel. +TEST_F(BrowserWindowControllerTest, TestIncognitoWidthSpace) { + scoped_ptr<TestingProfile> incognito_profile(new TestingProfile()); + incognito_profile->set_off_the_record(true); + scoped_ptr<Browser> browser(new Browser(Browser::TYPE_NORMAL, + incognito_profile.get())); + controller_.reset([[BrowserWindowController alloc] + initWithBrowser:browser.get() + takeOwnership:NO]); + + NSRect tabFrame = [[controller_ tabStripView] frame]; + [controller_ installIncognitoBadge]; + NSRect newTabFrame = [[controller_ tabStripView] frame]; + EXPECT_GT(tabFrame.size.width, newTabFrame.size.width); + + controller_.release(); +} +#endif + /* TODO(???): test other methods of BrowserWindowController */ |