diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-06 02:43:51 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-06 02:43:51 +0000 |
| commit | 5c87690ac9aed7e975132b301aed90abbe4e0550 (patch) | |
| tree | c882124c8abfa9f4e06f77c4f5a8ebb06cb301a9 /chrome/browser/cocoa/chrome_event_processing_window.h | |
| parent | 34437af8727dac421df5ff694eea7c8392ed1038 (diff) | |
| download | chromium_src-5c87690ac9aed7e975132b301aed90abbe4e0550.zip chromium_src-5c87690ac9aed7e975132b301aed90abbe4e0550.tar.gz chromium_src-5c87690ac9aed7e975132b301aed90abbe4e0550.tar.bz2 | |
Do not send input menu toggle events to the web.
This changes us back from the sendEvent:-based approach to the performKeyEquivalent:-based one. The main problem with the pKE: approach was that ctrl-tab toggled the view loop. However, I found an SPI in WebKit's source that enables us to work around that.
I tested lots of stuff, but there are of course chances that this regresses something. The only sane way to write unit tests for all that keyhandling crap however is to sendEvent: keys to NSApp and have a complete browser with renderers running, and browser tests don't work on OS X yet :-/
BUG=26115
TEST=Open SysPrefs->Keyboard and configure cmd-space to switch input languages. Go to a page that blocks js events (e.g. http://unixpapa.com/js/testkey.html , check the two left checkboxes), cmd-space should still switch input languages. ) All the cases listed at the end of http://sites.google.com/a/chromium.org/dev/developers/os-x-keyboard-handling .
Review URL: http://codereview.chromium.org/363024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31197 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/chrome_event_processing_window.h')
| -rw-r--r-- | chrome/browser/cocoa/chrome_event_processing_window.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/browser/cocoa/chrome_event_processing_window.h b/chrome/browser/cocoa/chrome_event_processing_window.h index 4f13c27..78cc747 100644 --- a/chrome/browser/cocoa/chrome_event_processing_window.h +++ b/chrome/browser/cocoa/chrome_event_processing_window.h @@ -18,10 +18,6 @@ BOOL eventHandled_; } -// Returns |YES| if |event| has been shortcircuited and should not be processed -// further. -- (BOOL)shortcircuitEvent:(NSEvent*)event; - // Sends an event to |NSApp sendEvent:|, but also makes sure that it's not // short-circuited to the RWHV. This is used to send keyboard events to the menu // and the cmd-` handler if a keyboard event comes back unhandled from the |