diff options
author | danno@chromium.org <danno@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-25 11:00:04 +0000 |
---|---|---|
committer | danno@chromium.org <danno@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-25 11:00:04 +0000 |
commit | 9b8b4d375a9ce7cc52b6d42046a4947f58b8648d (patch) | |
tree | aa62820d005c55aebeae5400bf88ff2215de2181 /chrome/browser/cocoa/cookie_details_view_controller.mm | |
parent | fcdec74769768ae107cc96216175bce243aab995 (diff) | |
download | chromium_src-9b8b4d375a9ce7cc52b6d42046a4947f58b8648d.zip chromium_src-9b8b4d375a9ce7cc52b6d42046a4947f58b8648d.tar.gz chromium_src-9b8b4d375a9ce7cc52b6d42046a4947f58b8648d.tar.bz2 |
[Mac] Make cookie prompt dialog more Mac-like
As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular.
Also added unit tests.
xib changes:
- Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly.
- Change the size of the radio buttons in the "remember" choice to be small rather than regular.
- Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string
- Move the details view to be below the accept/block buttons.
- Change the style of the disclosure control to be a button rather than triangle.
Before: http://img257.yfrog.com/img257/3066/picture3fx.png
After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png
BUG=38208
TEST=manual testing, added unit test for remember/block/accept controls
Review URL: http://codereview.chromium.org/1102005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/cookie_details_view_controller.mm')
-rw-r--r-- | chrome/browser/cocoa/cookie_details_view_controller.mm | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/cocoa/cookie_details_view_controller.mm b/chrome/browser/cocoa/cookie_details_view_controller.mm index ea1801f..1c97d19 100644 --- a/chrome/browser/cocoa/cookie_details_view_controller.mm +++ b/chrome/browser/cocoa/cookie_details_view_controller.mm @@ -19,6 +19,7 @@ static const int kMinimalLabelOffsetFromViewBottom = 20; #pragma mark View Controller @implementation CookieDetailsViewController +@dynamic hasExpiration; - (id)init { return [super initWithNibName:@"CookieDetailsView" @@ -97,8 +98,6 @@ static const int kMinimalLabelOffsetFromViewBottom = 20; [[[objectController_ content] details] setHasExpiration:YES]; } -@dynamic hasExpiration; - - (BOOL)hasExpiration { return [[[objectController_ content] details] hasExpiration]; } |