diff options
author | danno@chromium.org <danno@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-25 11:00:04 +0000 |
---|---|---|
committer | danno@chromium.org <danno@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-25 11:00:04 +0000 |
commit | 9b8b4d375a9ce7cc52b6d42046a4947f58b8648d (patch) | |
tree | aa62820d005c55aebeae5400bf88ff2215de2181 /chrome/browser/cocoa/cookie_prompt_window_controller.h | |
parent | fcdec74769768ae107cc96216175bce243aab995 (diff) | |
download | chromium_src-9b8b4d375a9ce7cc52b6d42046a4947f58b8648d.zip chromium_src-9b8b4d375a9ce7cc52b6d42046a4947f58b8648d.tar.gz chromium_src-9b8b4d375a9ce7cc52b6d42046a4947f58b8648d.tar.bz2 |
[Mac] Make cookie prompt dialog more Mac-like
As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular.
Also added unit tests.
xib changes:
- Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly.
- Change the size of the radio buttons in the "remember" choice to be small rather than regular.
- Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string
- Move the details view to be below the accept/block buttons.
- Change the style of the disclosure control to be a button rather than triangle.
Before: http://img257.yfrog.com/img257/3066/picture3fx.png
After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png
BUG=38208
TEST=manual testing, added unit test for remember/block/accept controls
Review URL: http://codereview.chromium.org/1102005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/cookie_prompt_window_controller.h')
-rw-r--r-- | chrome/browser/cocoa/cookie_prompt_window_controller.h | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/chrome/browser/cocoa/cookie_prompt_window_controller.h b/chrome/browser/cocoa/cookie_prompt_window_controller.h index 5276d5c..6ae68b4 100644 --- a/chrome/browser/cocoa/cookie_prompt_window_controller.h +++ b/chrome/browser/cocoa/cookie_prompt_window_controller.h @@ -35,8 +35,8 @@ class CookieTreeNode; // in the prompt window. IBOutlet NSTextField* description_; IBOutlet NSView* disclosedViewPlaceholder_; - IBOutlet NSButton* disclosureTriangle_; - IBOutlet NSView* disclosureTriangleSuperView_; + IBOutlet NSButton* disclosureButton_; + IBOutlet NSView* disclosureButtonSuperView_; IBOutlet NSMatrix* radioGroupMatrix_; IBOutlet NSButtonCell* rememberChoiceCell_; } @@ -50,7 +50,7 @@ class CookieTreeNode; // Handles the toggling of the disclosure triangle // to reveal cookie data -- (IBAction)disclosureTrianglePressed:(id)sender; +- (IBAction)disclosureButtonPressed:(id)sender; // Callback for "block" button. - (IBAction)block:(id)sender; @@ -58,4 +58,9 @@ class CookieTreeNode; // Callback for "accept" button. - (IBAction)accept:(id)sender; +// Processes the selection result code made in the cookie prompt. +// Part of the public interface for the tests. +- (void)processModalDialogResult:(void*)contextInfo + returnCode:(int)returnCode; + @end |