diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-16 21:36:10 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-16 21:36:10 +0000 |
| commit | c47ee3fe8eb962680d1597bc1e63c666833f1a57 (patch) | |
| tree | c6411a90be8806cd84f45edfbffe09a50056441d /chrome/browser/cocoa/download_item_cell.mm | |
| parent | 56c4456f31726d89bcaba8471ff71e097066907d (diff) | |
| download | chromium_src-c47ee3fe8eb962680d1597bc1e63c666833f1a57.zip chromium_src-c47ee3fe8eb962680d1597bc1e63c666833f1a57.tar.gz chromium_src-c47ee3fe8eb962680d1597bc1e63c666833f1a57.tar.bz2 | |
Mac: fix/implement app windows (not app mode), popups, drawing; refactor code.
1. Properly display app windows, including Developer Tools window (no location bar). Also check using --app=http://foobar.com/.
2. Lay out popup windows (in particular, location bar) better. Check using, e.g., <http://www.quirksmode.org/js/popup.html>; make sure it looks good (with a variety of themes).
3. Properly draw border to Omnibox -- so that its border matches the surrounding buttons. Check (looking very closely/zooming) using various themes (Google and artist, light and dark).
4. Re-organize/refactor code in the BrowserWindowController (esp. the layout code). Check that (in a normal window) it still displays the toolbar, bookmark bar (normal and NTP), infobar, and download shelf correctly.
BUG=13148,20244,26757,29103
TEST=See above.
Review URL: http://codereview.chromium.org/495010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34757 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/download_item_cell.mm')
| -rw-r--r-- | chrome/browser/cocoa/download_item_cell.mm | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/chrome/browser/cocoa/download_item_cell.mm b/chrome/browser/cocoa/download_item_cell.mm index 57d79e3..267fb0f 100644 --- a/chrome/browser/cocoa/download_item_cell.mm +++ b/chrome/browser/cocoa/download_item_cell.mm @@ -397,20 +397,12 @@ const int kCompleteAnimationDuration = 2.5; NSBezierPath* buttonInnerPath = [self leftRoundedPath:radius inRect:buttonDrawRect]; - NSBezierPath* buttonOuterPath = [self - leftRoundedPath:(radius + 1) - inRect:NSInsetRect(buttonDrawRect, -1, -1)]; - NSBezierPath* dropdownInnerPath = [self rightRoundedPath:radius inRect:dropdownDrawRect]; - NSBezierPath* dropdownOuterPath = [self - rightRoundedPath:(radius + 1) - inRect:NSInsetRect(dropdownDrawRect, -1, -1)]; // Stroke the borders and appropriate fill gradient. [self drawBorderAndFillForTheme:theme controlView:controlView - outerPath:buttonOuterPath innerPath:buttonInnerPath showClickedGradient:[self isButtonPartPressed] showHighlightGradient:[self isMouseOverButtonPart] @@ -421,7 +413,6 @@ const int kCompleteAnimationDuration = 2.5; [self drawBorderAndFillForTheme:theme controlView:controlView - outerPath:dropdownOuterPath innerPath:dropdownInnerPath showClickedGradient:[self isDropdownPartPressed] showHighlightGradient:[self isMouseOverDropdownPart] |