diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-19 03:52:11 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-19 03:52:11 +0000 |
| commit | 1a6b30a619cba771cb9c4ed4da9c3778634567ad (patch) | |
| tree | 4ced69ac8eb511a6f9bc7949348551ee62b57989 /chrome/browser/cocoa/event_utils.h | |
| parent | a8815b3277284778247545728bc41a077ff55b43 (diff) | |
| download | chromium_src-1a6b30a619cba771cb9c4ed4da9c3778634567ad.zip chromium_src-1a6b30a619cba771cb9c4ed4da9c3778634567ad.tar.gz chromium_src-1a6b30a619cba771cb9c4ed4da9c3778634567ad.tar.bz2 | |
This changelist represents the necessary merger of two others:
http://codereview.chromium.org/172082
Create new event_utils.h file for Cocoa-specific event to WindowOpenDisposition
cracking.
Hook this up to BookmarkBarController so that clicks to bookmark items use the
oracle function to determine where the bookmark should be opened.
BUG=17301
TEST=Cmd+Click etc on bookmark items should work. See bug and unit test
attached.
http://codereview.chromium.org/174021
Convert users of the "get last active browser, get selected tab contents, open
url" pattern to just call OpenURL on Browser directly.
Makes GetOrCreateTabbedBrowser public on Browser, and makes it static so it can
be called with a provided profile.
BUG=none
TEST=Try opening links from the bookmark/history menus on mac, with and without
an existing window open, with an active incognito window, etc. The links should
all open in the last active non-incognito window, or create a new non-incognito
window if none is open.
Review URL: http://codereview.chromium.org/173044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23693 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/event_utils.h')
| -rw-r--r-- | chrome/browser/cocoa/event_utils.h | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/event_utils.h b/chrome/browser/cocoa/event_utils.h new file mode 100644 index 0000000..7d0f87b --- /dev/null +++ b/chrome/browser/cocoa/event_utils.h @@ -0,0 +1,21 @@ +// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef CHROME_BROWSER_COCOA_EVENT_UTILS_H_ +#define CHROME_BROWSER_COCOA_EVENT_UTILS_H_ + +#import <Cocoa/Cocoa.h> + +#include "webkit/glue/window_open_disposition.h" + +namespace event_utils { + +// Retrieves the WindowOpenDisposition used to open a link from a user gesture +// represented by |event|. For example, a Cmd+Click would mean open the +// associated link in a background tab. +WindowOpenDisposition WindowOpenDispositionFromNSEvent(NSEvent* event); + +} // namespace event_utils + +#endif // CHROME_BROWSER_COCOA_EVENT_UTILS_H_ |