diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-26 21:45:34 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-26 21:45:34 +0000 |
| commit | 96788b0612875c0d12584757b63f02112e9541a7 (patch) | |
| tree | d7eb82156c83b850d2714110dd7d8bb7aad60c41 /chrome/browser/cocoa/extension_installed_bubble_controller.mm | |
| parent | 21ca7bf8f06e3b6e608f26eed8dce30515721b86 (diff) | |
| download | chromium_src-96788b0612875c0d12584757b63f02112e9541a7.zip chromium_src-96788b0612875c0d12584757b63f02112e9541a7.tar.gz chromium_src-96788b0612875c0d12584757b63f02112e9541a7.tar.bz2 | |
Mac: First run bubble.
Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it.
Move some l10n stuff to l10n_util and use that, too.
Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone())
BUG=27489,36366
TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work.
Review URL: http://codereview.chromium.org/2822026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50940 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/extension_installed_bubble_controller.mm')
| -rw-r--r-- | chrome/browser/cocoa/extension_installed_bubble_controller.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/extension_installed_bubble_controller.mm b/chrome/browser/cocoa/extension_installed_bubble_controller.mm index b255d0e..69046ec 100644 --- a/chrome/browser/cocoa/extension_installed_bubble_controller.mm +++ b/chrome/browser/cocoa/extension_installed_bubble_controller.mm @@ -225,7 +225,7 @@ class ExtensionLoadedNotificationObserver : public NotificationObserver { NSPoint origin = [parentWindow_ convertBaseToScreen:[self calculateArrowPoint]]; NSSize offsets = NSMakeSize(info_bubble::kBubbleArrowXOffset + - info_bubble::kBubbleArrowWidth / 2.0, 0); + info_bubble::kBubbleArrowWidth / 2.0, 0); offsets = [[window contentView] convertSize:offsets toView:nil]; origin.x -= NSWidth([window frame]) - offsets.width; origin.y -= NSHeight([window frame]); |