diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 02:40:07 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 02:40:07 +0000 |
| commit | 126f4120902008da93759d7256c87e1e6d3ae70b (patch) | |
| tree | ba664f25a7d09be02fc6c05802b938fba53683be /chrome/browser/cocoa/find_bar_bridge.mm | |
| parent | 627f02642ffe7075b567ee85e77044d64d72e24d (diff) | |
| download | chromium_src-126f4120902008da93759d7256c87e1e6d3ae70b.zip chromium_src-126f4120902008da93759d7256c87e1e6d3ae70b.tar.gz chromium_src-126f4120902008da93759d7256c87e1e6d3ae70b.tar.bz2 | |
FindBarView::UpdateForResult is not a good place to
beep if nothing was found on the page. The reason is
that it is gets called when you switch from one tab
to the other. I've added a function to FindBar that
the controller can call and each platform can
implement whatever sound they want to use.
BUG=10823
TEST=Open google.com, search for z0, it should beep
(no matches). Open new tab, switch back to the old
tab and it should not beep.
Review URL: http://codereview.chromium.org/99372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/find_bar_bridge.mm')
| -rw-r--r-- | chrome/browser/cocoa/find_bar_bridge.mm | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/find_bar_bridge.mm b/chrome/browser/cocoa/find_bar_bridge.mm index 8cb37e4..e7c2f9b 100644 --- a/chrome/browser/cocoa/find_bar_bridge.mm +++ b/chrome/browser/cocoa/find_bar_bridge.mm @@ -38,6 +38,11 @@ void FindBarBridge::UpdateUIForFindResult(const FindNotificationDetails& result, [cocoa_controller_ updateUIForFindResult:result withText:find_text]; } +void FindBarBridge::AudibleAlertIfNotFound( + const FindNotificationDetails& result) { + // TODO(rohitrao): Beep beep, beep beep, Yeah! +} + bool FindBarBridge::IsFindBarVisible() { return [cocoa_controller_ isFindBarVisible] ? true : false; } |