summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/find_bar_cocoa_controller.mm
diff options
context:
space:
mode:
authorthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-07 15:07:33 +0000
committerthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-07 15:07:33 +0000
commitdbae68bc1fed808acfcf50fa661005f2102c1dea (patch)
tree0340f433502faaa346f4633c698fe0e8117dbb75 /chrome/browser/cocoa/find_bar_cocoa_controller.mm
parentc08a12a70063ab74b5f7143cefecfdc5f9701fda (diff)
downloadchromium_src-dbae68bc1fed808acfcf50fa661005f2102c1dea.zip
chromium_src-dbae68bc1fed808acfcf50fa661005f2102c1dea.tar.gz
chromium_src-dbae68bc1fed808acfcf50fa661005f2102c1dea.tar.bz2
Let fn-left/right in find bar scroll to end of page.
BUG=none TEST=Open page with scrollbar, open and focus find bar. Hit fn-right, it should scroll to the end of the page. Hit fn-left, it should scroll back up. Review URL: http://codereview.chromium.org/246084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28249 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/find_bar_cocoa_controller.mm')
-rw-r--r--chrome/browser/cocoa/find_bar_cocoa_controller.mm7
1 files changed, 6 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/find_bar_cocoa_controller.mm b/chrome/browser/cocoa/find_bar_cocoa_controller.mm
index 265483e..9f4a62b 100644
--- a/chrome/browser/cocoa/find_bar_cocoa_controller.mm
+++ b/chrome/browser/cocoa/find_bar_cocoa_controller.mm
@@ -154,6 +154,8 @@ static float kFindBarCloseDuration = 0.15;
command == @selector(pageDown:) ||
command == @selector(pageDownAndModifySelection:) ||
command == @selector(scrollPageDown:) ||
+ command == @selector(scrollToBeginningOfDocument:) ||
+ command == @selector(scrollToEndOfDocument:) ||
command == @selector(moveUp:) ||
command == @selector(moveDown:)) {
TabContents* contents =
@@ -168,7 +170,10 @@ static float kFindBarCloseDuration = 0.15;
// Forward the event to the renderer.
// TODO(rohitrao): Should this call -[BaseView keyEvent:]? Is there code in
- // that function that we want to keep or avoid?
+ // that function that we want to keep or avoid? Calling
+ // |ForwardKeyboardEvent()| directly ignores edit commands, which breaks
+ // cmd-up/down if we ever decide to include |moveToBeginningOfDocument:| in
+ // the list above.
RenderViewHost* render_view_host = contents->render_view_host();
render_view_host->ForwardKeyboardEvent(NativeWebKeyboardEvent(event));
return YES;