Fix stuck hover states on tab close buttons

Use the |bounds| property instead of the |frame| property when updating tracking rectangles and deciding whether the button has the mouse over it.  We used to do this from the parent views context, but moved the code into the button itself and this broke.

Check the image state when the mouseDown event loop finishes.  We can get into a weird state when the tabs resize and the close button is placed under the cursor.  We update the image to highlight it, but if we click/hold the mouse button without moving the mouse, there are no mouseMove events and thus no mouseEntered, and thus no mouseExited (just assuming that's what is happening).

BUG=31279
TEST=Open a bunch of tabs, Click/hold on the last close button, then let go. Wit
hout moving the mouse at all, click/hold on the next button that moves under the
 mouse. Drag mouse away from tab strip area and let go. It should unhighlight it
self.

Review URL: http://codereview.chromium.org/524016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35678 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 0 deletions

diff --git a/chrome/browser/cocoa/hover_close_button.h b/chrome/browser/cocoa/hover_close_button.h
index ac42bf8..7c34395 100644
--- a/chrome/browser/cocoa/hover_close_button.h
+++ b/chrome/browser/cocoa/hover_close_button.h
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
+
 #include "base/scoped_nsobject.h"
 
 // The standard close button for our Mac UI which is the "x"
@@ -20,4 +21,11 @@
 // Sets up the button's images, tracking areas, and accessibility info
 // when instantiated via initWithFrame or awakeFromNib.
 - (void)commonInit;
+
+// Checks to see whether the mouse is in the button's bounds and update
+// the image in case it gets out of sync.  This occurs when you close a
+// tab so the tab to the left of it takes its place, and drag the button
+// without moving the mouse before you press the button down.
+- (void)checkImageState;
+
 @end