diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-15 17:34:59 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-15 17:34:59 +0000 |
| commit | a866cc21b77be5881eef0039db0b5928587f0b54 (patch) | |
| tree | 83c0375c7d2b1c48adb92cf41f981f5f84273d94 /chrome/browser/cocoa/info_bubble_window.h | |
| parent | e1df35e117fd5e243874bf9db9224b7112e51b34 (diff) | |
| download | chromium_src-a866cc21b77be5881eef0039db0b5928587f0b54.zip chromium_src-a866cc21b77be5881eef0039db0b5928587f0b54.tar.gz chromium_src-a866cc21b77be5881eef0039db0b5928587f0b54.tar.bz2 | |
Mac/clang: Possibly contentious changes.
As discussed on irc, we're getting rid of const NSObjects, and we're making all properties nonatomic.
const: All of cocoa takes nonconst NSObjects, and passing a const NSString to a function that takes NSString is a const violation. gcc doesn't complain about this, but clang intentionally does. constness is usually done via immutable base classes and mutable subclasses in cocoa anyway, so getting rid of const isn't that bad. Also, we don't really have a choice.
nonatomic: Some of our classes have custom setters that are not @synchronized. If the @property for that is not non-atomic, then the interface claims that the method is synchronized but the implementation actually isn't. That's a bug. gcc happens not to complain about this, but clang does. Since we shouldn't need atomic properties anywhere, the simple rule is now to just make all properties nonatomic.
Review URL: http://codereview.chromium.org/2769014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49808 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/info_bubble_window.h')
| -rw-r--r-- | chrome/browser/cocoa/info_bubble_window.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/info_bubble_window.h b/chrome/browser/cocoa/info_bubble_window.h index e5052c7..e8d8096 100644 --- a/chrome/browser/cocoa/info_bubble_window.h +++ b/chrome/browser/cocoa/info_bubble_window.h @@ -27,6 +27,6 @@ class AppNotificationBridge; // after the closing animation has completed. - (BOOL)isClosing; -@property BOOL delayOnClose; +@property (nonatomic) BOOL delayOnClose; @end |