diff options
| author | andybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-02 20:59:20 +0000 |
|---|---|---|
| committer | andybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-02 20:59:20 +0000 |
| commit | fac15c494ac3cacfcd905e8bc186ef212ad943e3 (patch) | |
| tree | 5d24e981bb9aec910946a1499e14a33b493502f3 /chrome/browser/cocoa/info_bubble_window.h | |
| parent | 8471424148c07642dee2796673feb2d66be75074 (diff) | |
| download | chromium_src-fac15c494ac3cacfcd905e8bc186ef212ad943e3.zip chromium_src-fac15c494ac3cacfcd905e8bc186ef212ad943e3.tar.gz chromium_src-fac15c494ac3cacfcd905e8bc186ef212ad943e3.tar.bz2 | |
[Mac] Make the extension popup a singleton instance to avoid maintaining multiple pointer references to a class that, by design, can only have one popup open at a time.
The bug fixed in this change has to do with PageActionView having a dirty pointer to a popup if it was closed via losing its key state. Once a notification like EXTENSION_HOST_VIEW_SHOULD_CLOSE was fired, then the PageActionView would assume the pointer was valid and call on dirty memory.
TEST=none
BUG=29492,33590
Review URL: http://codereview.chromium.org/561013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37873 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/info_bubble_window.h')
| -rw-r--r-- | chrome/browser/cocoa/info_bubble_window.h | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/chrome/browser/cocoa/info_bubble_window.h b/chrome/browser/cocoa/info_bubble_window.h index ab23b10..b0d05c5 100644 --- a/chrome/browser/cocoa/info_bubble_window.h +++ b/chrome/browser/cocoa/info_bubble_window.h @@ -15,16 +15,11 @@ BOOL delayOnClose_; } -@property BOOL delayOnClose; - -@end - -// Methods to only be used by unittests. -@interface InfoBubbleWindow (UnitTest) - // Returns YES if the window is in the process of closing. // Can't use "windowWillClose" notification because that will be sent // after the closing animation has completed. - (BOOL)isClosing; +@property BOOL delayOnClose; + @end |