diff options
author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-03 00:58:19 +0000 |
---|---|---|
committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-03 00:58:19 +0000 |
commit | 4baa9c88e98f72de4d2ebb2f4436834c8f9e2453 (patch) | |
tree | c1fc8c57dc05dbb2cb8825de007f222c39588d3f /chrome/browser/cocoa/preferences_window_controller.mm | |
parent | efff195424b347f56b9d56f8a1466a8b8d1334fd (diff) | |
download | chromium_src-4baa9c88e98f72de4d2ebb2f4436834c8f9e2453.zip chromium_src-4baa9c88e98f72de4d2ebb2f4436834c8f9e2453.tar.gz chromium_src-4baa9c88e98f72de4d2ebb2f4436834c8f9e2453.tar.bz2 |
Remove the AutoFill enable/disable radio from the Options dialog to the AutoFill dialog
These changes remove the AutoFill enabled radio buttons from the Preferences dialog and adds a single checkbox to the AutoFill dialog to do same. Preferences.xib changes by removing the radio buttons and moving other controls up. AutoFillDialog.xib adds checkbox to control AutoFill enabled preference. Also, other controls in AutoFillDialg.xib now bind their enabled states to the value of the enabled checkbox.
BUG=47435
TEST=AutoFillDialogControllerTest.AutoFillEnabled*
Review URL: http://codereview.chromium.org/2799054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51581 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/preferences_window_controller.mm')
-rw-r--r-- | chrome/browser/cocoa/preferences_window_controller.mm | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/chrome/browser/cocoa/preferences_window_controller.mm b/chrome/browser/cocoa/preferences_window_controller.mm index 039ac6f..8b511b2 100644 --- a/chrome/browser/cocoa/preferences_window_controller.mm +++ b/chrome/browser/cocoa/preferences_window_controller.mm @@ -344,7 +344,6 @@ CGFloat AutoSizeUnderTheHoodContent(NSView* view, - (void)setRestoreOnStartupIndex:(NSInteger)type; - (void)setShowHomeButton:(BOOL)value; - (void)setPasswordManagerEnabledIndex:(NSInteger)value; -- (void)setFormAutofillEnabledIndex:(NSInteger)value; - (void)setIsUsingDefaultTheme:(BOOL)value; - (void)setShowAlternateErrorPages:(BOOL)value; - (void)setUseSuggest:(BOOL)value; @@ -788,7 +787,6 @@ class ManagedPrefsBannerState : public ManagedPrefsBannerBase { // Personal Stuff panel askSavePasswords_.Init(prefs::kPasswordManagerEnabled, prefs_, observer_.get()); - formAutofill_.Init(prefs::kAutoFillEnabled, prefs_, observer_.get()); currentTheme_.Init(prefs::kCurrentThemeID, prefs_, observer_.get()); // Under the hood panel @@ -1233,10 +1231,6 @@ const int kDisabledIndex = 1; [self setPasswordManagerEnabledIndex:askSavePasswords_.GetValue() ? kEnabledIndex : kDisabledIndex]; } - if (*prefName == prefs::kAutoFillEnabled) { - [self setFormAutofillEnabledIndex:formAutofill_.GetValue() ? - kEnabledIndex : kDisabledIndex]; - } if (*prefName == prefs::kCurrentThemeID) { [self setIsUsingDefaultTheme:currentTheme_.GetValue().length() == 0]; } @@ -1356,18 +1350,6 @@ const int kDisabledIndex = 1; return askSavePasswords_.GetValue() ? kEnabledIndex : kDisabledIndex; } -- (void)setFormAutofillEnabledIndex:(NSInteger)value { - if (value == kEnabledIndex) - [self recordUserAction:UserMetricsAction("Options_FormAutofill_Enable")]; - else - [self recordUserAction:UserMetricsAction("Options_FormAutofill_Disable")]; - formAutofill_.SetValue(value == kEnabledIndex ? true : false); -} - -- (NSInteger)formAutofillEnabledIndex { - return formAutofill_.GetValue() ? kEnabledIndex : kDisabledIndex; -} - - (void)setIsUsingDefaultTheme:(BOOL)value { if (value) [self recordUserAction:UserMetricsAction( |