diff options
| author | alekseys@chromium.org <alekseys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-09 18:11:57 +0000 |
|---|---|---|
| committer | alekseys@chromium.org <alekseys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-09 18:11:57 +0000 |
| commit | a578606f5e15b4db72928f955995e71a92b683f9 (patch) | |
| tree | 188b1dec0f544a795dac8db48a0abe4aa7bbcf1c /chrome/browser/cocoa/side_tab_strip_controller.mm | |
| parent | a8c4602bfcedf0ad1ab0731bcfaa3da3c2e1cded (diff) | |
| download | chromium_src-a578606f5e15b4db72928f955995e71a92b683f9.zip chromium_src-a578606f5e15b4db72928f955995e71a92b683f9.tar.gz chromium_src-a578606f5e15b4db72928f955995e71a92b683f9.tar.bz2 | |
Move devtools and sidebar handling to BWC and ensure the order of layout adjustments
during tab change updates to eliminate UI flickering.
TabContents.xib changes: devtools and sidebar NSSplitViews removed (moved to BrowserWindow.xib),
contentsContainer_ view removed (now it's inserted at runtime).
BrowserWindow.xib chnages: devtools and sidebar NSSplitViews added into FastResizeView.
BUG=22717, 31633
TEST=Run unit_tests, browser_tests and interactive_ui_tests.
Open google.com in one tab (it's easy to spot content relayout on google.com), trigger an infobar
and content scroll bar on another tab (ru.wikipedia.org with translation infobar will do), switch
tabs back and forth. Content should not relayout, scroll bar should not "jump".
Open new tab and make sure bookmark bar is not always visible, open any site which triggers infobar
and big enough to show content scroll bar on another tab, switch tabs back and forth. Content should
not relayout, scroolbar should not "jump".
Repeat the tests above with sidebar opened on any of these tabs, page and sidebar content should not
relayout, sidebar should stay the same width, scrollbar should not "jump".
Repeat the tests above with devtools docked.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58964 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/side_tab_strip_controller.mm')
| -rw-r--r-- | chrome/browser/cocoa/side_tab_strip_controller.mm | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/cocoa/side_tab_strip_controller.mm b/chrome/browser/cocoa/side_tab_strip_controller.mm index 0f59329..9ff73d1 100644 --- a/chrome/browser/cocoa/side_tab_strip_controller.mm +++ b/chrome/browser/cocoa/side_tab_strip_controller.mm @@ -14,8 +14,12 @@ - (id)initWithView:(TabStripView*)view switchView:(NSView*)switchView - browser:(Browser*)browser { - self = [super initWithView:view switchView:switchView browser:browser]; + browser:(Browser*)browser + delegate:(id<TabStripControllerDelegate>)delegate { + self = [super initWithView:view + switchView:switchView + browser:browser + delegate:delegate]; if (self) { // Side tabs have no indent since they are not sharing space with the // window controls. |