diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 18:14:28 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 18:14:28 +0000 |
commit | 89622004872be7f7ddaa24fa1694f76c7b9539b6 (patch) | |
tree | 81b8a42c7649c8cbca99d04305470ccbc1fe61fa /chrome/browser/cocoa/tab_strip_controller.mm | |
parent | b7544eef7b81458a88597419eed6617c41e6d3dc (diff) | |
download | chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.zip chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.tar.gz chromium_src-89622004872be7f7ddaa24fa1694f76c7b9539b6.tar.bz2 |
UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/tab_strip_controller.mm')
-rw-r--r-- | chrome/browser/cocoa/tab_strip_controller.mm | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/chrome/browser/cocoa/tab_strip_controller.mm b/chrome/browser/cocoa/tab_strip_controller.mm index 9a661e4..cf340bb 100644 --- a/chrome/browser/cocoa/tab_strip_controller.mm +++ b/chrome/browser/cocoa/tab_strip_controller.mm @@ -573,7 +573,8 @@ private: TabContents* contents = tabStripModel_->GetTabContentsAt(index); if (contents) - UserMetrics::RecordAction("CloseTab_Mouse", contents->profile()); + UserMetrics::RecordAction(UserMetricsAction("CloseTab_Mouse"), + contents->profile()); const NSInteger numberOfOpenTabs = [self numberOfOpenTabs]; if (numberOfOpenTabs > 1) { bool isClosingLastTab = index == numberOfOpenTabs - 1; @@ -1567,12 +1568,14 @@ private: // Either insert a new tab or open in a current tab. switch (disposition) { case NEW_FOREGROUND_TAB: - UserMetrics::RecordAction("Tab_DropURLBetweenTabs", browser_->profile()); + UserMetrics::RecordAction(UserMetricsAction("Tab_DropURLBetweenTabs"), + browser_->profile()); browser_->AddTabWithURL(url, GURL(), PageTransition::TYPED, true, index, true, NULL); break; case CURRENT_TAB: - UserMetrics::RecordAction("Tab_DropURLOnTab", browser_->profile()); + UserMetrics::RecordAction(UserMetricsAction("Tab_DropURLOnTab"), + browser_->profile()); tabStripModel_->GetTabContentsAt(index)->OpenURL(url, GURL(), CURRENT_TAB, PageTransition::TYPED); tabStripModel_->SelectTabContentsAt(index, true); |