summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/tab_view.mm
diff options
context:
space:
mode:
authorpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-05 15:57:29 +0000
committerpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-05 15:57:29 +0000
commit210e33bb96f415629c4404b8b72199de80f3a33b (patch)
tree309386713031a028dd308a1b24681e04513e8bd5 /chrome/browser/cocoa/tab_view.mm
parentf3071247741d3c88d52c06613061e7f03a833769 (diff)
downloadchromium_src-210e33bb96f415629c4404b8b72199de80f3a33b.zip
chromium_src-210e33bb96f415629c4404b8b72199de80f3a33b.tar.gz
chromium_src-210e33bb96f415629c4404b8b72199de80f3a33b.tar.bz2
Add bugs, update, and remove TODOs that are no longer valid
BUG=none TEST=none Review URL: http://codereview.chromium.org/577021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38211 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/tab_view.mm')
-rw-r--r--chrome/browser/cocoa/tab_view.mm16
1 files changed, 4 insertions, 12 deletions
diff --git a/chrome/browser/cocoa/tab_view.mm b/chrome/browser/cocoa/tab_view.mm
index 8167071..c5dfd2a 100644
--- a/chrome/browser/cocoa/tab_view.mm
+++ b/chrome/browser/cocoa/tab_view.mm
@@ -180,11 +180,10 @@ const CGFloat kRapidCloseDist = 2.5;
if (chromeIsVisible_ == shouldBeVisible)
return;
- // TODO(pinkerton): There appears to be a race-condition in CoreAnimation
- // where if we use animators to set the alpha values, we can't guarantee
- // that we cancel them. This has the side effect of sometimes leaving
- // the dragged window translucent or invisible. We should re-visit this,
- // but for now, don't animate the alpha change.
+ // There appears to be a race-condition in CoreAnimation where if we use
+ // animators to set the alpha values, we can't guarantee that we cancel them.
+ // This has the side effect of sometimes leaving the dragged window
+ // translucent or invisible. As a result, don't animate the alpha change.
[[draggedController_ overlayWindow] setAlphaValue:1.0];
if (targetController_) {
[dragWindow_ setAlphaValue:0.0];
@@ -200,9 +199,6 @@ const CGFloat kRapidCloseDist = 2.5;
// Handle clicks and drags in this button. We get here because we have
// overridden acceptsFirstMouse: and the click is within our bounds.
-// TODO(pinkerton/alcor): This routine needs *a lot* of work to marry Cole's
-// ideas of dragging cocoa views between windows and how the Browser and
-// TabStrip models want to manage tabs.
- (void)mouseDown:(NSEvent*)theEvent {
if ([self isClosing])
return;
@@ -378,10 +374,6 @@ const CGFloat kRapidCloseDist = 2.5;
for (TabWindowController* target in targets) {
NSRect windowFrame = [[target window] frame];
if (NSPointInRect(thisPoint, windowFrame)) {
- // TODO(pinkerton): If bringing the window to the front immediately is too
- // annoying, use another dwell date. Can't use |targetDwellDate| because
- // this hasn't yet become the new target until the mouse is in the tab
- // strip.
[[target window] orderFront:self];
NSRect tabStripFrame = [[target tabStripView] frame];
tabStripFrame.origin = [[target window]