diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-16 21:36:10 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-16 21:36:10 +0000 |
| commit | c47ee3fe8eb962680d1597bc1e63c666833f1a57 (patch) | |
| tree | c6411a90be8806cd84f45edfbffe09a50056441d /chrome/browser/cocoa/tab_window_controller.mm | |
| parent | 56c4456f31726d89bcaba8471ff71e097066907d (diff) | |
| download | chromium_src-c47ee3fe8eb962680d1597bc1e63c666833f1a57.zip chromium_src-c47ee3fe8eb962680d1597bc1e63c666833f1a57.tar.gz chromium_src-c47ee3fe8eb962680d1597bc1e63c666833f1a57.tar.bz2 | |
Mac: fix/implement app windows (not app mode), popups, drawing; refactor code.
1. Properly display app windows, including Developer Tools window (no location bar). Also check using --app=http://foobar.com/.
2. Lay out popup windows (in particular, location bar) better. Check using, e.g., <http://www.quirksmode.org/js/popup.html>; make sure it looks good (with a variety of themes).
3. Properly draw border to Omnibox -- so that its border matches the surrounding buttons. Check (looking very closely/zooming) using various themes (Google and artist, light and dark).
4. Re-organize/refactor code in the BrowserWindowController (esp. the layout code). Check that (in a normal window) it still displays the toolbar, bookmark bar (normal and NTP), infobar, and download shelf correctly.
BUG=13148,20244,26757,29103
TEST=See above.
Review URL: http://codereview.chromium.org/495010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34757 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/tab_window_controller.mm')
| -rw-r--r-- | chrome/browser/cocoa/tab_window_controller.mm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/cocoa/tab_window_controller.mm b/chrome/browser/cocoa/tab_window_controller.mm index c8e881c..984ab35f 100644 --- a/chrome/browser/cocoa/tab_window_controller.mm +++ b/chrome/browser/cocoa/tab_window_controller.mm @@ -23,7 +23,7 @@ } - (void)windowDidLoad { - if ([self isNormalWindow]) { + if ([self hasTabStrip]) { // Place the tab bar above the content box and add it to the view hierarchy // as a sibling of the content view so it can overlap with the window frame. NSRect tabFrame = [tabContentArea_ frame]; @@ -199,8 +199,8 @@ return @""; } -- (BOOL)isNormalWindow { - // subclass must implement +- (BOOL)hasTabStrip { + // Subclasses should implement this. NOTIMPLEMENTED(); return YES; } |