diff options
author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
---|---|---|
committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
commit | 46ebf0640d32b313618fe443a34e959059b2c3f9 (patch) | |
tree | 84b616ce5385bce6c8d4b966e74daf7648fdc8c5 /chrome/browser/cocoa/table_row_nsimage_cache.h | |
parent | 7c543fd101874d1453dfcf9727dd0d39d296ef50 (diff) | |
download | chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.zip chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.gz chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.bz2 |
Add undeclared virtual destructors.
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
Review URL: http://codereview.chromium.org/2856051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/table_row_nsimage_cache.h')
-rw-r--r-- | chrome/browser/cocoa/table_row_nsimage_cache.h | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/chrome/browser/cocoa/table_row_nsimage_cache.h b/chrome/browser/cocoa/table_row_nsimage_cache.h index 6409123..a8c0052 100644 --- a/chrome/browser/cocoa/table_row_nsimage_cache.h +++ b/chrome/browser/cocoa/table_row_nsimage_cache.h @@ -15,15 +15,18 @@ // caches the results. class TableRowNSImageCache { public: - // Interface this cache expects for its table model. - class Table { - public: - // Returns the number of rows in the table. - virtual int RowCount() const = 0; - - // Returns the icon of the |row|th row. - virtual SkBitmap GetIcon(int row) const = 0; - }; + // Interface this cache expects for its table model. + class Table { + public: + // Returns the number of rows in the table. + virtual int RowCount() const = 0; + + // Returns the icon of the |row|th row. + virtual SkBitmap GetIcon(int row) const = 0; + + protected: + virtual ~Table() {} + }; // |model| must outlive the cache. explicit TableRowNSImageCache(Table* model); |