diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 01:16:14 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 01:16:14 +0000 |
| commit | 96373d08aa941358daef07d6a5c6ddf161ddb51a (patch) | |
| tree | 1590cd0b69f14faf6fc687eaa8911f9631b53ddf /chrome/browser/cocoa/task_manager_mac.mm | |
| parent | d345da8e3a16aa212e415eb58a259f45ca81ae77 (diff) | |
| download | chromium_src-96373d08aa941358daef07d6a5c6ddf161ddb51a.zip chromium_src-96373d08aa941358daef07d6a5c6ddf161ddb51a.tar.gz chromium_src-96373d08aa941358daef07d6a5c6ddf161ddb51a.tar.bz2 | |
Task Manager sorting:
- remove dead code that papered over the fact certain columns don't sort, replace with NOTREACHED pothole
- allow sorting by the javascript memory column.
- allow sorting by goats teleported (useful for debugging)
- stabilize \# of goats teleported (remove observer effect)
BUG=42037
TEST=sort by these columns in the task manager
Review URL: http://codereview.chromium.org/1706002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45139 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/task_manager_mac.mm')
| -rw-r--r-- | chrome/browser/cocoa/task_manager_mac.mm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/cocoa/task_manager_mac.mm b/chrome/browser/cocoa/task_manager_mac.mm index 2249c47..b0a70a6 100644 --- a/chrome/browser/cocoa/task_manager_mac.mm +++ b/chrome/browser/cocoa/task_manager_mac.mm @@ -324,8 +324,8 @@ static const struct ColumnWidth { return base::SysWideToNSString(model_->GetResourceGoatsTeleported(row)); default: - return base::SysWideToNSString( - model_->GetResourceStatsValue(row, columnId)); + NOTREACHED(); + return @""; } } |