diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-14 00:58:17 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-14 00:58:17 +0000 |
| commit | 7a1951a2d5a549f49714aa243c5f51fa9b86f7a8 (patch) | |
| tree | 07805676229df685a71734c3a1b031168af057d1 /chrome/browser/cocoa/toolbar_controller_unittest.mm | |
| parent | 7cd22a5102842cfbb51e06c626d769d81bb78210 (diff) | |
| download | chromium_src-7a1951a2d5a549f49714aa243c5f51fa9b86f7a8.zip chromium_src-7a1951a2d5a549f49714aa243c5f51fa9b86f7a8.tar.gz chromium_src-7a1951a2d5a549f49714aa243c5f51fa9b86f7a8.tar.bz2 | |
More bookmark bar changes.
* Applied memory cleanliness fix in unit test; follow-up from
http://codereview.chromium.org/149308.
* Move bookmark bar into it's own nib; minor code refactor to
accomodate.
* The toolbar STAR button somehow lost it's action; added it back in.
* Implemented delete bookmark notification callback so we behave
(remove button from the screen) when a bookmark is deleted.
* Added context menus for the bookmark bar and bookmark buttons.
* Hooked up a handful of these menu items. E.g.
- open in new tab, window, incog window
- delete bookmark (finally)
- bookmark manager (which then hits a NOTIMPLEMENTED())
- always show bookmark bar
* Truncate bookmark button text on end, not on middle.
Experimental to look more like Windows.
It looks cleaner but is less Mac-like.
* Add "draws border when mouse goes over" for bookmark buttons. Need
to do it by hand since we have a custom button drawing method.
BUG=crbug.com/8381
TEST=Here's a list:
- Make sure the bookmark buttons don't have a border unless the mouse is over them
- Toolbar "STAR" should now add bookmarks when clicked
- Test context menus on bookmark buttons, and the bar itself
- Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g.
Right click on bookmark --> delete menu item should delete button
Review URL: http://codereview.chromium.org/155358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20591 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa/toolbar_controller_unittest.mm')
| -rw-r--r-- | chrome/browser/cocoa/toolbar_controller_unittest.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/toolbar_controller_unittest.mm b/chrome/browser/cocoa/toolbar_controller_unittest.mm index 93e1cfe..ed3cf89 100644 --- a/chrome/browser/cocoa/toolbar_controller_unittest.mm +++ b/chrome/browser/cocoa/toolbar_controller_unittest.mm @@ -22,7 +22,7 @@ class ToolbarControllerTest : public testing::Test { // |-toolbarViews| method. enum { kBackIndex, kForwardIndex, kReloadIndex, kHomeIndex, kStarIndex, kGoIndex, - kPageIndex, kWrenchIndex, kLocationIndex, kBookmarkIndex, + kPageIndex, kWrenchIndex, kLocationIndex, }; ToolbarControllerTest() { |