[Mac]Implement ViewID support. (third approach)

This CL adds several extension methods to NSView class for ViewID
support, and uses a map to store ViewIDs of views.
Each view requiring ViewID support can set its ViewID upon
initialization and unset it before destruction.
When looking up a view with a specific ViewID, just search all sub views
recursively from the root view of a window.

BUG=44692 need ViewIds on mac
TEST=none

Review URL: http://codereview.chromium.org/2878037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53067 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 107 insertions, 0 deletions

diff --git a/chrome/browser/cocoa/view_id_util_browsertest.mm b/chrome/browser/cocoa/view_id_util_browsertest.mm
new file mode 100644
index 0000000..de4d425
--- /dev/null
+++ b/chrome/browser/cocoa/view_id_util_browsertest.mm
@@ -0,0 +1,107 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/bookmarks/bookmark_model.h"
+#include "chrome/browser/browser.h"
+#include "chrome/browser/browser_window.h"
+#include "chrome/browser/cocoa/view_id_util.h"
+#include "chrome/browser/download/download_shelf.h"
+#include "chrome/browser/pref_service.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/test/in_process_browser_test.h"
+#include "chrome/test/ui_test_utils.h"
+
+// Basic sanity check of ViewID use on the mac.
+class ViewIDTest : public InProcessBrowserTest {
+ public:
+  ViewIDTest() : root_window_(nil) {}
+
+  void CheckViewID(ViewID view_id, bool should_have) {
+    if (!root_window_)
+      root_window_ = browser()->window()->GetNativeHandle();
+
+    ASSERT_TRUE(root_window_);
+    NSView* view = view_id_util::GetView(root_window_, view_id);
+    EXPECT_EQ(should_have, !!view) << " Failed id=" << view_id;
+  }
+
+  void DoTest() {
+    // Make sure FindBar is created to test
+    // VIEW_ID_FIND_IN_PAGE_TEXT_FIELD and VIEW_ID_FIND_IN_PAGE.
+    browser()->ShowFindBar();
+
+    // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
+    browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsOpenDocked,
+                                                 true);
+    browser()->ToggleDevToolsWindow(DEVTOOLS_TOGGLE_ACTION_INSPECT);
+
+    // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
+    browser()->window()->GetDownloadShelf()->Show();
+
+    // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT
+    BookmarkModel* bookmark_model = browser()->profile()->GetBookmarkModel();
+    if (bookmark_model) {
+      if (!bookmark_model->IsLoaded())
+        ui_test_utils::WaitForBookmarkModelToLoad(bookmark_model);
+
+      bookmark_model->SetURLStarred(GURL(chrome::kAboutBlankURL),
+                                    UTF8ToUTF16("about"), true);
+    }
+
+    for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
+      // Extension shelf is being removed, http://crbug.com/30178.
+      if (i == VIEW_ID_DEV_EXTENSION_SHELF)
+        continue;
+
+      // Mac implementation does not support following ids yet.
+      if (i == VIEW_ID_STAR_BUTTON ||
+          i == VIEW_ID_PAGE_MENU ||
+          i == VIEW_ID_AUTOCOMPLETE ||
+          i == VIEW_ID_CONTENTS_SPLIT) {
+        continue;
+      }
+
+      CheckViewID(static_cast<ViewID>(i), true);
+    }
+
+    CheckViewID(VIEW_ID_TAB, true);
+    CheckViewID(VIEW_ID_TAB_STRIP, true);
+    CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);
+  }
+
+ private:
+  NSWindow* root_window_;
+};
+
+IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) {
+  ASSERT_NO_FATAL_FAILURE(DoTest());
+}
+
+IN_PROC_BROWSER_TEST_F(ViewIDTest, Fullscreen) {
+  browser()->window()->SetFullscreen(true);
+  ASSERT_NO_FATAL_FAILURE(DoTest());
+}
+
+IN_PROC_BROWSER_TEST_F(ViewIDTest, Tab) {
+  CheckViewID(VIEW_ID_TAB_0, true);
+  CheckViewID(VIEW_ID_TAB_LAST, true);
+
+  // Open 9 new tabs.
+  for (int i = 1; i <= 9; ++i) {
+    CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), false);
+    browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(),
+                       NEW_BACKGROUND_TAB, PageTransition::TYPED);
+    CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), true);
+    // VIEW_ID_TAB_LAST should always be available.
+    CheckViewID(VIEW_ID_TAB_LAST, true);
+  }
+
+  // Open the 11th tab.
+  browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(),
+                     NEW_BACKGROUND_TAB, PageTransition::TYPED);
+  CheckViewID(VIEW_ID_TAB_LAST, true);
+}