diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 21:41:16 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-16 21:41:16 +0000 |
commit | 6c69796dfc4e3c4fe1c6c0d7c561d3f17a3e18a9 (patch) | |
tree | 18375c7ebd926415dbc1371de37e5945528c6b30 /chrome/browser/cocoa | |
parent | aa561d95543b80f81781e2c332b271a044c134c6 (diff) | |
download | chromium_src-6c69796dfc4e3c4fe1c6c0d7c561d3f17a3e18a9.zip chromium_src-6c69796dfc4e3c4fe1c6c0d7c561d3f17a3e18a9.tar.gz chromium_src-6c69796dfc4e3c4fe1c6c0d7c561d3f17a3e18a9.tar.bz2 |
Download code cleanup: split big files into smaller one.
It's hard to find things in the download directory. DownloadFile and DownloadFileManager
were bundled together. Similarly for DownloadItem and DownloadManager, which was much less
intuitive. Some 3-5 line structs were also in one bag with something else. I extracted them
to their own small file.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/2806054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52749 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa')
-rw-r--r-- | chrome/browser/cocoa/download_item_cell.mm | 1 | ||||
-rw-r--r-- | chrome/browser/cocoa/download_item_controller.mm | 1 | ||||
-rw-r--r-- | chrome/browser/cocoa/download_item_mac.h | 1 | ||||
-rw-r--r-- | chrome/browser/cocoa/download_item_mac.mm | 1 | ||||
-rw-r--r-- | chrome/browser/cocoa/download_shelf_controller.mm | 3 | ||||
-rw-r--r-- | chrome/browser/cocoa/download_util_mac.mm | 1 |
6 files changed, 7 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/download_item_cell.mm b/chrome/browser/cocoa/download_item_cell.mm index c9843aba..8ae9fd9 100644 --- a/chrome/browser/cocoa/download_item_cell.mm +++ b/chrome/browser/cocoa/download_item_cell.mm @@ -12,6 +12,7 @@ #import "chrome/browser/cocoa/download_item_cell.h" #import "chrome/browser/cocoa/image_utils.h" #import "chrome/browser/cocoa/themed_window.h" +#include "chrome/browser/download/download_item.h" #include "chrome/browser/download/download_item_model.h" #include "chrome/browser/download/download_manager.h" #include "chrome/browser/download/download_util.h" diff --git a/chrome/browser/cocoa/download_item_controller.mm b/chrome/browser/cocoa/download_item_controller.mm index 61b0aa3..00e2110 100644 --- a/chrome/browser/cocoa/download_item_controller.mm +++ b/chrome/browser/cocoa/download_item_controller.mm @@ -18,6 +18,7 @@ #import "chrome/browser/cocoa/download_shelf_controller.h" #import "chrome/browser/cocoa/themed_window.h" #import "chrome/browser/cocoa/ui_localizer.h" +#include "chrome/browser/download/download_item.h" #include "chrome/browser/download/download_item_model.h" #include "chrome/browser/download/download_shelf.h" #include "chrome/browser/download/download_util.h" diff --git a/chrome/browser/cocoa/download_item_mac.h b/chrome/browser/cocoa/download_item_mac.h index a54abe4..91a8702 100644 --- a/chrome/browser/cocoa/download_item_mac.h +++ b/chrome/browser/cocoa/download_item_mac.h @@ -10,6 +10,7 @@ #include "base/scoped_nsobject.h" #include "base/scoped_ptr.h" #include "chrome/browser/cancelable_request.h" +#include "chrome/browser/download/download_item.h" #include "chrome/browser/download/download_manager.h" #include "chrome/browser/icon_manager.h" diff --git a/chrome/browser/cocoa/download_item_mac.mm b/chrome/browser/cocoa/download_item_mac.mm index 7bc3b25..b2aae2c 100644 --- a/chrome/browser/cocoa/download_item_mac.mm +++ b/chrome/browser/cocoa/download_item_mac.mm @@ -8,6 +8,7 @@ #include "chrome/browser/browser_process.h" #import "chrome/browser/cocoa/download_item_controller.h" #include "chrome/browser/cocoa/download_util_mac.h" +#include "chrome/browser/download/download_item.h" #include "chrome/browser/download/download_item_model.h" #include "skia/ext/skia_utils_mac.h" diff --git a/chrome/browser/cocoa/download_shelf_controller.mm b/chrome/browser/cocoa/download_shelf_controller.mm index 53501c3..7fa1bf9 100644 --- a/chrome/browser/cocoa/download_shelf_controller.mm +++ b/chrome/browser/cocoa/download_shelf_controller.mm @@ -17,6 +17,7 @@ #include "chrome/browser/cocoa/download_shelf_mac.h" #import "chrome/browser/cocoa/download_shelf_view.h" #import "chrome/browser/cocoa/hyperlink_button_cell.h" +#include "chrome/browser/download/download_item.h" #include "chrome/browser/download/download_manager.h" #include "chrome/browser/profile.h" #include "grit/generated_resources.h" @@ -90,7 +91,7 @@ const NSTimeInterval kDownloadShelfCloseDuration = 0.12; selector:@selector(viewFrameDidChange:) name:NSViewFrameDidChangeNotification object:[self view]]; - + ResourceBundle& rb = ResourceBundle::GetSharedInstance(); NSImage* favicon = rb.GetNSImageNamed(IDR_DOWNLOADS_FAVICON); DCHECK(favicon); diff --git a/chrome/browser/cocoa/download_util_mac.mm b/chrome/browser/cocoa/download_util_mac.mm index 75a75ec..9364520 100644 --- a/chrome/browser/cocoa/download_util_mac.mm +++ b/chrome/browser/cocoa/download_util_mac.mm @@ -8,6 +8,7 @@ #include "base/sys_string_conversions.h" #import "chrome/browser/cocoa/dock_icon.h" +#include "chrome/browser/download/download_item.h" #include "chrome/browser/download/download_manager.h" #include "gfx/native_widget_types.h" #include "skia/ext/skia_utils_mac.h" |