diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-14 15:53:13 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-14 15:53:13 +0000 |
| commit | c07cfb808dbd642bb3385f974be296797bd34524 (patch) | |
| tree | 2834f7923f749d5fdc1246888ca7caf5b0cf507f /chrome/browser/cocoa | |
| parent | a68b966e94845efaa30dae71f4ca7c324eba57b9 (diff) | |
| download | chromium_src-c07cfb808dbd642bb3385f974be296797bd34524.zip chromium_src-c07cfb808dbd642bb3385f974be296797bd34524.tar.gz chromium_src-c07cfb808dbd642bb3385f974be296797bd34524.tar.bz2 | |
Add match count text to the GTK find bar. This also makes the bar wider.
The match count text doesn't currently show up realiably because the data in
the find reply is bad. I believe this is bug 11761.
The clicker checking code has been moved to the cross-platform
FindBarController so it doesn't have to be duplicated for each platform.
This also add IntToString16. I didnt add all the variants now. The *Wstring
versions should all eventually be changed to string16.
http://crbug.com/11750
Review URL: http://codereview.chromium.org/114023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16058 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa')
| -rw-r--r-- | chrome/browser/cocoa/find_bar_cocoa_controller.mm | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/cocoa/find_bar_cocoa_controller.mm b/chrome/browser/cocoa/find_bar_cocoa_controller.mm index 43123bf..cedc89a 100644 --- a/chrome/browser/cocoa/find_bar_cocoa_controller.mm +++ b/chrome/browser/cocoa/find_bar_cocoa_controller.mm @@ -139,9 +139,6 @@ // otherwise match counts won't work on Mac and Linux. NSString* searchString = [findText_ stringValue]; if ([searchString length] > 0) { - // TODO(rohitrao): Implement similar logic as in FindBarWin, to - // avoid flickering when searching. For now, only update the - // results label if both our numbers are non-negative. if (result.active_match_ordinal() >= 0 && result.number_of_matches() >= 0) { [resultsLabel_ setStringValue:base::SysWideToNSString( l10n_util::GetStringF(IDS_FIND_IN_PAGE_COUNT, |