diff options
| author | davidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-10 00:15:35 +0000 |
|---|---|---|
| committer | davidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-10 00:15:35 +0000 |
| commit | 95a8885c7470e8a4572fa672728ba948535f2da1 (patch) | |
| tree | af36bdfef2dd30550b077258c36ebf45fd599aa1 /chrome/browser/cocoa | |
| parent | dbec3790ae6053744920c3c85eab1bccd32b8016 (diff) | |
| download | chromium_src-95a8885c7470e8a4572fa672728ba948535f2da1.zip chromium_src-95a8885c7470e8a4572fa672728ba948535f2da1.tar.gz chromium_src-95a8885c7470e8a4572fa672728ba948535f2da1.tar.bz2 | |
Make GTK certificate selection dialog a constrained window
This makes the dialog tab-modal. Implementation on OS X is
forthcoming. Windows will be messier; we'll need to implement our own dialog,
but we want that anyway because of the annoying blocking call.
R=wtc,mattm
TEST=none
BUG=50710
Review URL: http://codereview.chromium.org/3077008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55509 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa')
| -rw-r--r-- | chrome/browser/cocoa/ssl_client_certificate_selector.mm | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/browser/cocoa/ssl_client_certificate_selector.mm b/chrome/browser/cocoa/ssl_client_certificate_selector.mm index 4475bb9..82d9822 100644 --- a/chrome/browser/cocoa/ssl_client_certificate_selector.mm +++ b/chrome/browser/cocoa/ssl_client_certificate_selector.mm @@ -17,6 +17,7 @@ #include "base/sys_string_conversions.h" #include "chrome/browser/chrome_thread.h" #include "chrome/browser/ssl/ssl_client_auth_handler.h" +#include "chrome/browser/tab_contents/tab_contents.h" #include "grit/generated_resources.h" #include "net/base/x509_certificate.h" @@ -40,15 +41,16 @@ namespace browser { void ShowSSLClientCertificateSelector( - gfx::NativeWindow parent, + TabContents* parent, net::SSLCertRequestInfo* cert_request_info, SSLClientAuthHandler* delegate) { + // TODO(davidben): Implement a tab-modal dialog. DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI)); SSLClientCertificateSelectorCocoa* selector = [[[SSLClientCertificateSelectorCocoa alloc] initWithHandler:delegate certRequestInfo:cert_request_info] autorelease]; - [selector displayDialog:parent]; + [selector displayDialog:parent->GetMessageBoxRootWindow()]; } } // namespace browser |