diff options
| author | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 20:10:57 +0000 |
|---|---|---|
| committer | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-21 20:10:57 +0000 |
| commit | 458697b2e4c2954d22497323f68c668a47e92faa (patch) | |
| tree | fe8e50c5e0c6097ab2dc306d56081edce45e9b83 /chrome/browser/cocoa | |
| parent | 4d0aeb3183c83c9ebd7ec5e81747a3e7152797fb (diff) | |
| download | chromium_src-458697b2e4c2954d22497323f68c668a47e92faa.zip chromium_src-458697b2e4c2954d22497323f68c668a47e92faa.tar.gz chromium_src-458697b2e4c2954d22497323f68c668a47e92faa.tar.bz2 | |
Fix bug whereby an installed page action bubble points not at the page action icon.
BUG= 41374
TEST= install a page action extension. "installed bubble" points at the icon that was installed. it should work for multiple icons.
Review URL: http://codereview.chromium.org/1762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45228 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa')
| -rw-r--r-- | chrome/browser/cocoa/extension_installed_bubble_controller.mm | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/cocoa/extension_installed_bubble_controller.mm b/chrome/browser/cocoa/extension_installed_bubble_controller.mm index fac8384..3cfba62 100644 --- a/chrome/browser/cocoa/extension_installed_bubble_controller.mm +++ b/chrome/browser/cocoa/extension_installed_bubble_controller.mm @@ -189,10 +189,13 @@ class ExtensionLoadedNotificationObserver : public NotificationObserver { size_t index = locationBarView->GetPageActionIndex(extension_->page_action()); NSRect iconRect = [[field autocompleteTextFieldCell] - pageActionFrameForIndex:index inFrame:[field frame]]; + pageActionFrameForIndex:index inFrame:[field bounds]]; NSRect boundsrect = [[field superview] convertRect:iconRect toView:nil]; - arrowPoint = NSMakePoint(NSMidX(boundsrect) + 1, NSMinY(boundsrect)); + NSRect fieldFrame = [field bounds]; + fieldFrame = [field convertRect:fieldFrame toView:nil]; + arrowPoint = NSMakePoint(fieldFrame.origin.x + NSMidX(boundsrect), + NSMinY(boundsrect)); break; } default: { |