diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 18:09:37 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 18:09:37 +0000 |
| commit | 8030f01f1f6e77e0ba72c591680a546da82f21f9 (patch) | |
| tree | f643e742dcc2ccca5da232c1c7d6964b20a79090 /chrome/browser/cocoa | |
| parent | cdacb88cb3d3b11f21caae229816a68cab3170b2 (diff) | |
| download | chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.zip chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.tar.gz chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.tar.bz2 | |
Makes it so that you shouldn't be able to get a big fat bookmark
bar. This happened because when we changed from needing a
bookmarkbar/extension-shelf to not needing one we processed the layout
change asynchronously, but could paint immediately and painting always
checks the current state. I initially made painting/layout stay in
sync with regards to whether they thought the bookmark bar should be
shown, which also fixes this, but because we process the change async
there was still some noticable jank. Instead I've changed processing
of the transition from needing bars to not (or vice-versa) to be
synchronous.
BUG=22165
TEST=see bug
Review URL: http://codereview.chromium.org/219034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27218 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa')
| -rw-r--r-- | chrome/browser/cocoa/browser_window_cocoa.h | 1 | ||||
| -rw-r--r-- | chrome/browser/cocoa/browser_window_cocoa.mm | 7 |
2 files changed, 8 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/browser_window_cocoa.h b/chrome/browser/cocoa/browser_window_cocoa.h index bdc105b..922e4f3 100644 --- a/chrome/browser/cocoa/browser_window_cocoa.h +++ b/chrome/browser/cocoa/browser_window_cocoa.h @@ -40,6 +40,7 @@ class BrowserWindowCocoa : public BrowserWindow, virtual void SelectedTabToolbarSizeChanged(bool is_animating); virtual void SelectedTabExtensionShelfSizeChanged(); virtual void UpdateTitleBar(); + virtual void ShelfVisibilityChanged(); virtual void UpdateDevTools(); virtual void FocusDevTools(); virtual void UpdateLoadingAnimations(bool should_animate); diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm index 12dab28..63cd96e 100644 --- a/chrome/browser/cocoa/browser_window_cocoa.mm +++ b/chrome/browser/cocoa/browser_window_cocoa.mm @@ -110,6 +110,13 @@ void BrowserWindowCocoa::UpdateTitleBar() { [window_ setMiniwindowTitle:newTitle]; } +void BrowserWindowCocoa::ShelfVisibilityChanged() { + // Mac doesn't yet support showing the bookmark bar at a different size on + // the new tab page. When it does, this method should attempt to relayout the + // bookmark bar/extension shelf as their preferred height may have changed. + NOTIMPLEMENTED(); +} + void BrowserWindowCocoa::UpdateDevTools() { NOTIMPLEMENTED(); } |