diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-30 22:08:32 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-30 22:08:32 +0000 |
| commit | 93538a959049371a4b60c6caf806b75d8a18b7e8 (patch) | |
| tree | 7064c50945060444f1b7d922b1ee35881ff30e0b /chrome/browser/cocoa | |
| parent | 003115b235d75df8b05ff25f75d27d90ad68b1d7 (diff) | |
| download | chromium_src-93538a959049371a4b60c6caf806b75d8a18b7e8.zip chromium_src-93538a959049371a4b60c6caf806b75d8a18b7e8.tar.gz chromium_src-93538a959049371a4b60c6caf806b75d8a18b7e8.tar.bz2 | |
Fix for
http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1303/steps/valgrind%20test:%20unit/logs/stdio
Review URL: http://codereview.chromium.org/151107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19666 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cocoa')
| -rw-r--r-- | chrome/browser/cocoa/browser_window_controller.mm | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/chrome/browser/cocoa/browser_window_controller.mm b/chrome/browser/cocoa/browser_window_controller.mm index 7e1d9aa..6e7b629 100644 --- a/chrome/browser/cocoa/browser_window_controller.mm +++ b/chrome/browser/cocoa/browser_window_controller.mm @@ -647,8 +647,16 @@ willPositionSheet:(NSWindow *)sheet [content removeFromSuperview]; [window_ setContentView:content]; [self setWindow:window_.get()]; - [window_ makeKeyAndOrderFront:self]; [content setNeedsDisplay:YES]; + + // With this call, valgrind yells at me about "Conditional jump or + // move depends on uninitialised value(s)". The error happens in + // -[NSThemeFrame drawOverlayRect:]. I'm pretty convinced this is + // an Apple bug, but there is no visual impact. I have been + // unable to tickle it away with other window or view manipulation + // Cocoa calls. Stack added to suppressions_mac.txt. + [window_ makeKeyAndOrderFront:self]; + [fullscreen_window_ close]; fullscreen_window_.reset(nil); } |