diff options
| author | scr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-21 01:33:52 +0000 |
|---|---|---|
| committer | scr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-21 01:33:52 +0000 |
| commit | 4c37b45dd79d8a78c3e54ce34d01ac6f96281c0c (patch) | |
| tree | 5d38891ef01e9a3a0e08eacfca591b7bce761f48 /chrome/browser/component_updater | |
| parent | 3c99d2c8a26c5b2297f36900c3e277360c1f120a (diff) | |
| download | chromium_src-4c37b45dd79d8a78c3e54ce34d01ac6f96281c0c.zip chromium_src-4c37b45dd79d8a78c3e54ce34d01ac6f96281c0c.tar.gz chromium_src-4c37b45dd79d8a78c3e54ce34d01ac6f96281c0c.tar.bz2 | |
Coverity Fixlet: fix PASS_BY_VALUE.
CID=102146
R=cpu@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9004037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115255 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/component_updater')
| -rw-r--r-- | chrome/browser/component_updater/component_updater_service.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/browser/component_updater/component_updater_service.cc b/chrome/browser/component_updater/component_updater_service.cc index 699dbc5..1578247 100644 --- a/chrome/browser/component_updater/component_updater_service.cc +++ b/chrome/browser/component_updater/component_updater_service.cc @@ -41,8 +41,10 @@ using content::BrowserThread; namespace { // Extends an omaha compatible update check url |query| string. Does // not mutate the string if it would be longer than |limit| chars. -bool AddQueryString(std::string id, std::string version, - size_t limit, std::string* query) { +bool AddQueryString(const std::string& id, + const std::string& version, + size_t limit, + std::string* query) { std::string additional = base::StringPrintf("id=%s&v=%s&uc", id.c_str(), version.c_str()); additional = "x=" + net::EscapeQueryParamValue(additional, true); |