diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
commit | 528c56de01bbbd38788ed6cf8d2eea4c56cbe19e (patch) | |
tree | ac4f7a001affd772c4ab89701d3d46109b5f9e19 /chrome/browser/config_dir_policy_provider_unittest.cc | |
parent | 5c86ada8d84f6e67d17b027d347052ef451241c4 (diff) | |
download | chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.zip chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.gz chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.bz2 |
Move the number conversions from string_util to a new file.
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/config_dir_policy_provider_unittest.cc')
-rw-r--r-- | chrome/browser/config_dir_policy_provider_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/config_dir_policy_provider_unittest.cc b/chrome/browser/config_dir_policy_provider_unittest.cc index c992ff3..14dad65 100644 --- a/chrome/browser/config_dir_policy_provider_unittest.cc +++ b/chrome/browser/config_dir_policy_provider_unittest.cc @@ -4,7 +4,7 @@ #include "base/file_util.h" #include "base/path_service.h" -#include "base/string_util.h" +#include "base/string_number_conversions.h" #include "chrome/browser/config_dir_policy_provider.h" #include "chrome/browser/mock_configuration_policy_store.h" #include "chrome/common/json_value_serializer.h" @@ -93,12 +93,12 @@ TEST_F(ConfigDirPolicyProviderTest, ReadPrefsMergePrefs) { DictionaryValue test_dict_bar; test_dict_bar.SetString(L"HomepageLocation", L"http://bar.com"); for (unsigned int i = 1; i <= 4; ++i) - WriteConfigFile(test_dict_bar, IntToString(i)); + WriteConfigFile(test_dict_bar, base::IntToString(i)); DictionaryValue test_dict_foo; test_dict_foo.SetString(L"HomepageLocation", L"http://foo.com"); WriteConfigFile(test_dict_foo, "9"); for (unsigned int i = 5; i <= 8; ++i) - WriteConfigFile(test_dict_bar, IntToString(i)); + WriteConfigFile(test_dict_bar, base::IntToString(i)); ConfigDirPolicyProvider provider(test_dir_); EXPECT_TRUE(provider.Provide(policy_store_.get())); |