diff options
author | jorlow@chromium.org <jorlow@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-17 21:35:08 +0000 |
---|---|---|
committer | jorlow@chromium.org <jorlow@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-17 21:35:08 +0000 |
commit | 37e050cf1d493e210ac6035c1ff45ccb1784c69b (patch) | |
tree | 4f4fc7766e17084d44eff9ca637a78f950c43ddb /chrome/browser/cookie_modal_dialog.h | |
parent | f2e5f9dbec4e957fbf709afefd49813b5515b846 (diff) | |
download | chromium_src-37e050cf1d493e210ac6035c1ff45ccb1784c69b.zip chromium_src-37e050cf1d493e210ac6035c1ff45ccb1784c69b.tar.gz chromium_src-37e050cf1d493e210ac6035c1ff45ccb1784c69b.tar.bz2 |
When we're initializing the modal dialog box which asks whether the page has permission to access a "cookie", double check that the value has not since been set. If it has, close the window before it's even shown.
This is a stop-gap solution. We should probably come up with something more elegent long term.
TEST=Go to a page that starts a database transaction and immediately sets a local storage value. You should get one prompt instead of 2.
BUG=36006
Review URL: http://codereview.chromium.org/619009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39270 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cookie_modal_dialog.h')
-rw-r--r-- | chrome/browser/cookie_modal_dialog.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/cookie_modal_dialog.h b/chrome/browser/cookie_modal_dialog.h index 6410c32..c5cb8bd 100644 --- a/chrome/browser/cookie_modal_dialog.h +++ b/chrome/browser/cookie_modal_dialog.h @@ -55,8 +55,9 @@ class CookiePromptModalDialog : public AppModalDialog { const string16& local_storage_key() const { return local_storage_key_; } const string16& local_storage_value() const { return local_storage_value_; } const string16& database_name() const { return database_name_; } + TabContents* tab_contents() const { return tab_contents_; } - // Send a response to our delegate. + // Implement CookiePromptModalDialogDelegate. void AllowSiteData(bool remember, bool session_expire); void BlockSiteData(bool remember); |