diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-22 01:05:23 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-22 01:05:23 +0000 |
| commit | 18cc5ff8be2bcd41bb1ec60c88e36214fe334ceb (patch) | |
| tree | d80407a45543cf123f9b7f328fcb38bde280792d /chrome/browser/cookies_tree_model_unittest.cc | |
| parent | fc11a6acf6bf1091014b5f8178548ad33b0895b9 (diff) | |
| download | chromium_src-18cc5ff8be2bcd41bb1ec60c88e36214fe334ceb.zip chromium_src-18cc5ff8be2bcd41bb1ec60c88e36214fe334ceb.tar.gz chromium_src-18cc5ff8be2bcd41bb1ec60c88e36214fe334ceb.tar.bz2 | |
Improve the algorithm of TreeNode::Remove.
Now it uses the same algorithm used in ui/views/view.[cc,h] of RemoveChildView.
R=sky@chromium.org
BUG=None
TEST=out/Debug/app_unittests --gtest_filter=TreeNodeModelTest.*
Review URL: http://codereview.chromium.org/6714034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78953 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/cookies_tree_model_unittest.cc')
| -rw-r--r-- | chrome/browser/cookies_tree_model_unittest.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/chrome/browser/cookies_tree_model_unittest.cc b/chrome/browser/cookies_tree_model_unittest.cc index cc61b59..acafc7d5 100644 --- a/chrome/browser/cookies_tree_model_unittest.cc +++ b/chrome/browser/cookies_tree_model_unittest.cc @@ -204,15 +204,14 @@ class CookiesTreeModelTest : public testing::Test { CookieTreeNode::DetailedInfo::TYPE_INDEXED_DB); } - // do not call on the root + // Do not call on the root. void DeleteStoredObjects(CookieTreeNode* node) { node->DeleteStoredObjects(); - // find the parent and index CookieTreeNode* parent_node = node->parent(); DCHECK(parent_node); - int ct_node_index = parent_node->GetIndexOf(node); - delete parent_node->GetModel()->Remove(parent_node, ct_node_index); + delete parent_node->GetModel()->Remove(parent_node, node); } + protected: MessageLoop message_loop_; BrowserThread ui_thread_; |