diff options
author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
---|---|---|
committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
commit | 46ebf0640d32b313618fe443a34e959059b2c3f9 (patch) | |
tree | 84b616ce5385bce6c8d4b966e74daf7648fdc8c5 /chrome/browser/crash_handler_host_linux.h | |
parent | 7c543fd101874d1453dfcf9727dd0d39d296ef50 (diff) | |
download | chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.zip chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.gz chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.bz2 |
Add undeclared virtual destructors.
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
Review URL: http://codereview.chromium.org/2856051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/crash_handler_host_linux.h')
-rw-r--r-- | chrome/browser/crash_handler_host_linux.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/crash_handler_host_linux.h b/chrome/browser/crash_handler_host_linux.h index 3f1ea2e..8a76297 100644 --- a/chrome/browser/crash_handler_host_linux.h +++ b/chrome/browser/crash_handler_host_linux.h @@ -38,7 +38,7 @@ class CrashHandlerHostLinux : public MessageLoopForIO::Watcher, protected: CrashHandlerHostLinux(); - ~CrashHandlerHostLinux(); + virtual ~CrashHandlerHostLinux(); // This is here on purpose to make CrashHandlerHostLinux abstract. virtual void SetProcessType() = 0; @@ -60,7 +60,7 @@ class PluginCrashHandlerHostLinux : public CrashHandlerHostLinux { PluginCrashHandlerHostLinux() { SetProcessType(); } - ~PluginCrashHandlerHostLinux() {} + virtual ~PluginCrashHandlerHostLinux() {} virtual void SetProcessType() { process_type_ = "plugin"; @@ -75,7 +75,7 @@ class RendererCrashHandlerHostLinux : public CrashHandlerHostLinux { RendererCrashHandlerHostLinux() { SetProcessType(); } - ~RendererCrashHandlerHostLinux() {} + virtual ~RendererCrashHandlerHostLinux() {} virtual void SetProcessType() { process_type_ = "renderer"; |