diff options
author | sdefresne <sdefresne@chromium.org> | 2015-08-06 01:51:55 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-08-06 08:52:35 +0000 |
commit | 44eb1f20ab04cb90b7ec6ae6eec67671ab2f9041 (patch) | |
tree | b43b0b2dba44192e307070589dbb8c9cc4ad74a9 /chrome/browser/crash_upload_list.h | |
parent | 2595929afa1296eb18700245fc7f62248ce4a2c8 (diff) | |
download | chromium_src-44eb1f20ab04cb90b7ec6ae6eec67671ab2f9041.zip chromium_src-44eb1f20ab04cb90b7ec6ae6eec67671ab2f9041.tar.gz chromium_src-44eb1f20ab04cb90b7ec6ae6eec67671ab2f9041.tar.bz2 |
Componentize upload_list.{h,cc} and crash_upload_list.{h,cc}.
Componentize upload_list.{h,cc} and crash_upload_list.{h,cc} so
that the code can be shared with iOS. Do not move the factory
function into the component (as it depends on //content) nor
the system specific sub-classes of CrashUploadList (as they depends
on //components/crash that cannot be used on iOS).
Remove the dependency on content::BrowserThread by injecting the
base::SequencedWorkerPool, passing the base::SequencedTaskRunner
to LoadUploadListAndInformDelegateOfCompletion and checking the
thread using base::ThreadChecker.
BUG=516343
Review URL: https://codereview.chromium.org/1269073002
Cr-Commit-Position: refs/heads/master@{#342079}
Diffstat (limited to 'chrome/browser/crash_upload_list.h')
-rw-r--r-- | chrome/browser/crash_upload_list.h | 27 |
1 files changed, 6 insertions, 21 deletions
diff --git a/chrome/browser/crash_upload_list.h b/chrome/browser/crash_upload_list.h index c81caef..f73d7cc 100644 --- a/chrome/browser/crash_upload_list.h +++ b/chrome/browser/crash_upload_list.h @@ -5,27 +5,12 @@ #ifndef CHROME_BROWSER_CRASH_UPLOAD_LIST_H_ #define CHROME_BROWSER_CRASH_UPLOAD_LIST_H_ -#include "chrome/browser/upload_list.h" +#include "base/memory/ref_counted.h" +#include "components/upload_list/crash_upload_list.h" -// An upload list manager for crash reports from breakpad. -class CrashUploadList : public UploadList { - public: - // Static factory method that creates the platform-specific implementation - // of the crash upload list with the given callback delegate. - static CrashUploadList* Create(Delegate* delegate); - - // Should match kReporterLogFilename in - // breakpad/src/client/apple/Framework/BreakpadDefines.h. - static const char* kReporterLogFilename; - - // Creates a new crash upload list with the given callback delegate. - CrashUploadList(Delegate* delegate, const base::FilePath& upload_log_path); - - protected: - ~CrashUploadList() override; - - private: - DISALLOW_COPY_AND_ASSIGN(CrashUploadList); -}; +// Factory that creates the platform-specific implementation of the crash +// upload list with the given callback delegate. +scoped_refptr<CrashUploadList> CreateCrashUploadList( + UploadList::Delegate* delegate); #endif // CHROME_BROWSER_CRASH_UPLOAD_LIST_H_ |